Guessing at fixes for Shibboleth issues. #2608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two problems with the Shibboleth authenticaiton that I have identified in discussion with @glarose together with analyzing code and the issues posted in the forums (see https://webwork.maa.org/moodle/mod/forum/discuss.php?d=8534#p21568). The first is that the Shibboleth module overrides the WeBWorK::Authen check_session method, and does not properly initialize the database session. This causes anything that uses the database session (which includes test proctor authentication) to fail. The second is that the WeBWorK::Controller session method returns undefined in the case that cookies are disabled (which the Shibboleth authentication module does). The Mojolicious::Plugin::DefaultHelpers _validation method then calls the session method expecting it to be an object or a hash reference. I have no way to test that this fixes the issues that have been reported, and can only write code that should work. So someone with a Shibboleth identity provider will need to test this.
drgrice1
force-pushed
the
shibboleth-guess
branch
from
fd6676d
to
641ed8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems with the Shibboleth authenticaiton that I have identified in discussion with @glarose together with analyzing code and the issues posted in the forums (see
https://webwork.maa.org/moodle/mod/forum/discuss.php?d=8534#p21568).
The first is that the Shibboleth module overrides the WeBWorK::Authen check_session method, and does not properly initialize the database session. This causes anything that uses the database session (which includes test proctor authentication) to fail.
The second is that the WeBWorK::Controller session method returns undefined in the case that cookies are disabled (which the Shibboleth authentication module does). The Mojolicious::Plugin::DefaultHelpers _validation method then calls the session method expecting it to be an object or a hash reference.
I have no way to test that this fixes the issues that have been reported, and can only write code that should work. So someone with a Shibboleth identity provider will need to test this.