Change key bindings for folding in PGCodeMirror. (Hotfix of #2594) #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
previously approved these changes
Oct 8, 2024
somiaj
force-pushed
the
code-mirror-key-bindings-hotfix
branch
from
ef9b7a4
to
29092ab
Compare
By default code mirror uses Shift-Ctrl-F for find/replace and Shift-Ctrl-G for find previous. These key bindings were overwritten when folding was added. This changes the fold binding to Shift-Ctrl-[ (or Shift-Cmd-[), fold all to Ctrl-Alt-[ (Cmd-Alt-[) and unfold all to Ctrl-Alt-] (Cmd-Alt-]), so they no longer interfere with the find/replace key bindings.
somiaj
force-pushed
the
code-mirror-key-bindings-hotfix
branch
from
29092ab
to
3696063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default code mirror uses Shift-Ctrl-F for find/replace and Shift-Ctrl-G for find previous. These key bindings were overwritten when folding was added.
This changes the fold binding to Shift-Ctrl-[ (or Shift-Cmd-[), fold all to Ctrl-Alt-[ (Cmd-Alt-[) and unfold all to Ctrl-Alt-] (Cmd-Alt-]), so they no longer interfere with the find/replace key bindings.