Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”¨ Refactor Visualisation #1693

Merged

Conversation

ashwinvaidya17
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 commented Jan 30, 2024

πŸ“ Description

  • Refactor visualisation

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to go over it quickly, and only have super minor comments. Will hopefully go for another round.

src/anomalib/callbacks/visualizer.py Outdated Show resolved Hide resolved
src/anomalib/callbacks/visualizer.py Show resolved Hide resolved
src/anomalib/callbacks/visualizer.py Outdated Show resolved Hide resolved
src/anomalib/utils/visualization/base.py Outdated Show resolved Hide resolved
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@blaz-r
Copy link
Contributor

blaz-r commented Jan 30, 2024

Just to make sure, is the center-crop issue (#1660, #1447) addressed in this?

@ashwinvaidya17
Copy link
Collaborator Author

Just to make sure, is the center-crop issue (#1660, #1447) addressed in this?

Ah thanks for the reminder. This does not address the centre-crop issue. I'll add it to my list

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ashwinvaidya17, looks good to me!

@samet-akcay samet-akcay enabled auto-merge (squash) January 31, 2024 17:37
@samet-akcay samet-akcay merged commit 73dce55 into openvinotoolkit:main Jan 31, 2024
5 of 7 checks passed
adrianboguszewski pushed a commit to adrianboguszewski/anomalib that referenced this pull request Feb 9, 2024
* Restore visualization changes

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* Fix tests + address PR comments

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* Refactor visualizer assignment

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* Update docstrings

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* Fix visualizer tests:

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

---------

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants