-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¨ Refactor Visualisation #1693
Merged
samet-akcay
merged 6 commits into
openvinotoolkit:main
from
ashwinvaidya17:refactor/visualization
Jan 31, 2024
Merged
π¨ Refactor Visualisation #1693
samet-akcay
merged 6 commits into
openvinotoolkit:main
from
ashwinvaidya17:refactor/visualization
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samet-akcay
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to go over it quickly, and only have super minor comments. Will hopefully go for another round.
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
ashwinvaidya17
force-pushed
the
refactor/visualization
branch
from
January 30, 2024 14:39
f1b0bd7
to
a4907cc
Compare
samet-akcay
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ashwinvaidya17, looks good to me!
adrianboguszewski
pushed a commit
to adrianboguszewski/anomalib
that referenced
this pull request
Feb 9, 2024
* Restore visualization changes Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Fix tests + address PR comments Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Refactor visualizer assignment Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Update docstrings Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Fix visualizer tests: Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> --------- Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
β¨ Changes
Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps: