Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tab keybinding invalid when always visible #4075

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Oct 10, 2024

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

修复了在 alwaysVisible 配置开启后,按 tab 不会采纳内敛补全的行为

@opensumi opensumi bot added the 🐞 bug Something isn't working label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 54.40%. Comparing base (7e0bbe0) to head (dd9af33).
Report is 1 commits behind head on v3.4.

Files with missing lines Patch % Lines
...-completions/intelligent-completions.controller.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v3.4    #4075      +/-   ##
==========================================
- Coverage   54.41%   54.40%   -0.01%     
==========================================
  Files        1590     1590              
  Lines       97268    97275       +7     
  Branches    19906    19898       -8     
==========================================
- Hits        52924    52920       -4     
- Misses      36830    36840      +10     
- Partials     7514     7515       +1     
Flag Coverage Δ
jsdom 49.94% <0.00%> (-0.01%) ⬇️
node 15.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet merged commit 9c0d68a into v3.4 Oct 11, 2024
12 checks passed
@Ricbet Ricbet deleted the fix/intelligent-tab-accept branch October 11, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants