-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing ajv dep for keymaps package #4072
Conversation
facecfe
to
9c68f8d
Compare
/next |
Walkthrough在此次更改中, Changes
Sequence Diagram(s)sequenceDiagram
participant A as User
participant B as Keymaps Package
participant C as Dependency Manager
A->>B: 请求使用 Keymaps
B->>C: 检查依赖项
C-->>B: 依赖项 ajv 已添加
B-->>A: 返回 Keymaps 功能
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (1)
- packages/keymaps/package.json (1 hunks)
🧰 Additional context used
🎉 PR Next publish successful! 3.4.2-next-1728550681.0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4072 +/- ##
==========================================
- Coverage 54.41% 54.40% -0.01%
==========================================
Files 1590 1590
Lines 97268 97268
Branches 19898 19906 +8
==========================================
- Hits 52924 52921 -3
- Misses 36830 36832 +2
- Partials 7514 7515 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/backport to v3.4 |
Backporting to |
Types
Background or solution
keymaps 服务实际上依赖了 ajv,添加以防止在某些情况下引用到错误的 ajv lib
https://github.com/opensumi/core/blob/main/packages/keymaps/src/browser/keymaps-parser.ts#L1
Changelog
无
Summary by CodeRabbit
@opensumi/ide-keymaps
包中新增了对ajv
依赖的支持。