Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing ajv dep for keymaps package #4072

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

MMhunter
Copy link
Contributor

@MMhunter MMhunter commented Oct 10, 2024

Types

  • 🧹 Chores

Background or solution

keymaps 服务实际上依赖了 ajv,添加以防止在某些情况下引用到错误的 ajv lib

https://github.com/opensumi/core/blob/main/packages/keymaps/src/browser/keymaps-parser.ts#L1

Changelog

Summary by CodeRabbit

  • 新特性
    • @opensumi/ide-keymaps 包中新增了对 ajv 依赖的支持。

@MMhunter MMhunter force-pushed the feat/add-missing-ajv-dep-for-keymaps branch from facecfe to 9c68f8d Compare October 10, 2024 08:54
@MMhunter
Copy link
Contributor Author

/next

Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Walkthrough

在此次更改中,@opensumi/ide-keymaps 包的 package.json 文件被更新,新增了对 ajv 版本 ^6.10.0 的依赖。现有的依赖项 @opensumi/ide-core-common 保持不变。文件的结构和内容没有其他修改。

Changes

文件路径 更改摘要
packages/keymaps/package.json 新增依赖项: "ajv": "^6.10.0"

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as Keymaps Package
    participant C as Dependency Manager

    A->>B: 请求使用 Keymaps
    B->>C: 检查依赖项
    C-->>B: 依赖项 ajv 已添加
    B-->>A: 返回 Keymaps 功能
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a08cb41 and 9c68f8d.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • packages/keymaps/package.json (1 hunks)
🧰 Additional context used

packages/keymaps/package.json Show resolved Hide resolved
@opensumi
Copy link
Contributor

opensumi bot commented Oct 10, 2024

🎉 PR Next publish successful!

3.4.2-next-1728550681.0

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.40%. Comparing base (a08cb41) to head (9c68f8d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4072      +/-   ##
==========================================
- Coverage   54.41%   54.40%   -0.01%     
==========================================
  Files        1590     1590              
  Lines       97268    97268              
  Branches    19898    19906       +8     
==========================================
- Hits        52924    52921       -3     
- Misses      36830    36832       +2     
- Partials     7514     7515       +1     
Flag Coverage Δ
jsdom 49.95% <ø> (-0.01%) ⬇️
node 15.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 7377d41 into main Oct 11, 2024
13 checks passed
@erha19 erha19 deleted the feat/add-missing-ajv-dep-for-keymaps branch October 11, 2024 02:42
@bytemain
Copy link
Member

/backport to v3.4

@opensumi
Copy link
Contributor

opensumi bot commented Oct 11, 2024

Backporting to v3.4 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants