feat: support terminal intelligence #3390

life2015 · 2024-03-11T02:57:04Z

终端的智能补全能力

终端的智能补全能力是指终端在输入命令时，能够根据用户的输入，自动提示可能的命令或参数，交互方式类似于编程时的语言服务。

此功能可以增加用户使用终端时的易用性。

功能建设

功能建设进度

Types

实验性支持了终端的智能补全，体验打磨中。

🎉 New Features

Background or solution

目前 Warp, FIg 这类终端智能产品越来越多，相关的用户心智和社区基建也愈发成熟。
并且在前段时间我们完成了对 Xterm.js Decoration 相关技术的掌握，因此基于 Xterm.js Decoration 和 inShellisense 项目的 Runtime 做出了 OpenSumi 上终端智能的实现。

Changelog

feat: (alpha) support terminal intelligence

railway-app · 2024-03-11T02:57:07Z

This PR was not deployed automatically as @life2015 does not have access to the Railway project.

In order to get automatic PR deploys, please add @life2015 to the project inside the project settings page.

erha19 · 2024-03-11T03:06:20Z

讨论是否需要转移补全逻辑到 Node.js

@life2015 个人感觉补全逻辑不应该挪到 NodeJS，相应的数据逻辑倒是可以灵活有点，一个实际状况是这种补全能力，在纯前端上面应该是个痛点，在本地场景，可能还会与系统的一些 GhostText 补全（例如安装了 zsh）冲突

可以基于 WebC 搞个版本，接入 AI 的上下文补全来搞一下？

life2015 · 2024-03-11T03:15:35Z

讨论是否需要转移补全逻辑到 Node.js

@life2015 个人感觉补全逻辑不应该挪到 NodeJS，相应的数据逻辑倒是可以灵活有点，一个实际状况是这种补全能力，在纯前端上面应该是个痛点，在本地场景，可能还会与系统的一些 GhostText 补全（例如安装了 zsh）冲突

可以基于 WebC 搞个版本，接入 AI 的上下文补全来搞一下？

是的，在纯前端场景上也能享受到终端智能补全能力是我把核心 Runtime 放到前端的主要原因。当时参考的 Fig 以及 inShellisense 都是基于 Node.js 来跑的，我做了一些前端的迁移和适配，理论上把 FS 读取和 Fig Generators 对 bash 的调用做后端代理之后，前后端的功能差异不会很大。

其实对于 OpenSumi 完整版而言，后端实现会更容易，前段实现难一些，不过目前前端实现我也已经跑通了，就是需要再衡量一下两条路线，我个人也是倾向于前端方案，这样会方便未来一些纯前端场景的接入。

目前来看，支持 WebC 的问题不大。我们后续需要把前端对后端的依赖层做一个抽象，然后分开传统场景，WebC，以及云终端各种场景做分别的注入。

life2015 · 2024-05-29T07:38:06Z

全面更新终端补全能力的交互 99ad0be

life2015 · 2024-05-30T10:07:40Z

Terminal 智能的底层补全逻辑做了大规模重构，核心逻辑放置于 common，环境相关的逻辑可以单独在 Browser 或者 Node.js 层实现。目前是采用了 Node.js 层实现，通过覆写两个 Class 即可做到。

TODO:
一些交互闪烁和布局问题
cwd 感知有问题

codecov · 2024-06-12T10:36:26Z

Codecov Report

Attention: Patch coverage is 13.07815% with 545 lines in your changes missing coverage. Please review.

Project coverage is 54.96%. Comparing base (ef65ac4) to head (5be010d).

Files	Patch %	Lines
...ackages/terminal-next/src/common/intell/runtime.ts	6.89%	113 Missing and 49 partials ⚠️
...ages/terminal-next/src/common/intell/suggestion.ts	11.23%	114 Missing and 44 partials ⚠️
...rminal-next/src/node/terminal.intell.enviroment.ts	18.00%	35 Missing and 6 partials ⚠️
...ckages/terminal-next/src/common/intell/template.ts	12.50%	32 Missing and 3 partials ⚠️
packages/terminal-next/src/common/intell/parser.ts	10.52%	21 Missing and 13 partials ⚠️
...minal-next/src/node/terminal.intell.spec.loader.ts	8.10%	27 Missing and 7 partials ⚠️
...kages/terminal-next/src/common/intell/generator.ts	20.51%	21 Missing and 10 partials ⚠️
...ages/terminal-next/src/common/intell/utils/ansi.ts	0.00%	15 Missing and 8 partials ⚠️
...erminal-next/src/node/stupid-shell-intergration.ts	0.00%	9 Missing ⚠️
...-next/src/browser/contribution/terminal.command.ts	0.00%	7 Missing and 1 partial ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3390      +/-   ##
==========================================
- Coverage   55.25%   54.96%   -0.29%     
==========================================
  Files        1545     1557      +12     
  Lines       94179    94806     +627     
  Branches    19331    19532     +201     
==========================================
+ Hits        52035    52114      +79     
- Misses      34978    35384     +406     
- Partials     7166     7308     +142

Flag	Coverage Δ
jsdom	`50.39% <0.15%> (-0.34%)`	⬇️
node	`15.52% <13.07%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/terminal-next/src/node/bundle.js

packages/terminal-next/src/browser/component/terminal-intell-complete-controller.tsx

packages/terminal-next/src/browser/intell/intell-terminal.service.tsx

packages/terminal-next/src/common/intell/model.ts

bytemain · 2024-06-18T08:58:35Z

packages/terminal-next/src/browser/component/terminal-intell-complete-controller.module.less

+  left: 0;
+
+  // TODO 考虑动态设置字体
+  font-family: Menlo, Monaco, 'Courier New', monospace;


调整成 opensumi 全局用的 font-family 吧，代码库里搜一下

packages/terminal-next/src/browser/component/terminal-intell-complete-controller.tsx

bytemain · 2024-06-18T09:01:29Z

packages/terminal-next/src/browser/intell/intell-terminal.service.tsx

+
+  private initContainer() {
+    this.popupContainer = document.createElement('div');
+    this.popupContainer.style.zIndex = '12';


不要 hard code，记在 StackingLevel 这个枚举值里

bytemain · 2024-06-18T09:01:40Z

packages/terminal-next/src/browser/intell/intell-terminal.service.tsx

+        this.listenPromptState(client.term);
+      } catch (e) {
+        // eslint-disable-next-line no-console
+        console.error('listenTerminalEvent', e);


使用 this.logger

bytemain · 2024-06-18T09:05:25Z

packages/terminal-next/src/browser/intell/intell-terminal.service.tsx

+  private getConnection(xterm: Terminal): ITerminalConnection {
+    // @ts-ignore
+    // 目前需要强制取用 Addon 的 connection 能力
+    const attachAddon = xterm._addonManager._addons.find((addon) => !!addon?.instance?.connection);


attachAddon 里就有 connection, attachAddon 可以在 TerminalClient 里拿到。

可以看看 https://github.com/opensumi/core/pull/3390/files#diff-ffe2330864e5dbde73f2b9622b05274eaf2f8d98cd7daea1d80277e8be4f8a48R72

TerminalClient 是一个 xterm 渲染的起始位置，肯定是可以拿到这个 attachAddon 的

·

life2015 requested review from erha19, bytemain and Aaaaash March 11, 2024 02:57

opensumi bot added the 🎨 feature feature required label Mar 11, 2024

erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024

life2015 added 2 commits May 24, 2024 11:45

feat: terminal intell new

064e050

fix: compile error fix

dd4e0a1

life2015 force-pushed the feat/terminal-intell-alpha branch from d7eb345 to dd4e0a1 Compare May 29, 2024 07:19

feat: optimize and redesign terminal complete ui

99ad0be

life2015 changed the title ~~feat: (alpha) support terminal intelligence~~ feat: (beta) support terminal intelligence May 30, 2024

feat: refactor terminal intell runtime, support both browser and node

0a39956

life2015 added 2 commits June 4, 2024 13:53

feat: support cwd change

1e3a35e

feat: support terminal intell complete settings

dd50f0d

life2015 and others added 6 commits June 13, 2024 10:55

feat: adjust style

73ac689

chore: lint fix

9115d6d

feat: support fig insertValue

2232750

chore: fix lint

066eee5

feat: terminal intell settings i18n

9d5f094

Merge branch 'main' into feat/terminal-intell-alpha

9fecbb2

life2015 changed the title ~~feat: (beta) support terminal intelligence~~ feat: support terminal intelligence Jun 13, 2024

Ricbet reviewed Jun 13, 2024

View reviewed changes

packages/terminal-next/src/node/bundle.js Outdated Show resolved Hide resolved

Ricbet reviewed Jun 14, 2024

View reviewed changes

life2015 added 2 commits June 14, 2024 11:39

chore: remove obsolete bundle.js

3f7f5a2

chore: more copyright info, use runWhenIdle

3ca4696

life2015 added 2 commits June 14, 2024 16:22

Merge branch 'main' into feat/terminal-intell-alpha

ee98762

Merge branch 'main' into feat/terminal-intell-alpha

5be010d

bytemain previously requested changes Jun 18, 2024

View reviewed changes

erha19 self-assigned this Oct 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support terminal intelligence #3390

feat: support terminal intelligence #3390

life2015 commented Mar 11, 2024 •

edited

Loading

railway-app bot commented Mar 11, 2024

erha19 commented Mar 11, 2024 •

edited

Loading

life2015 commented Mar 11, 2024 •

edited

Loading

life2015 commented May 29, 2024

life2015 commented May 30, 2024

codecov bot commented Jun 12, 2024 •

edited

Loading

bytemain Jun 18, 2024

bytemain Jun 18, 2024

bytemain Jun 18, 2024

bytemain Jun 18, 2024

feat: support terminal intelligence #3390

Are you sure you want to change the base?

feat: support terminal intelligence #3390

Conversation

life2015 commented Mar 11, 2024 • edited Loading

终端的智能补全能力

功能建设

Types

Background or solution

Changelog

railway-app bot commented Mar 11, 2024

erha19 commented Mar 11, 2024 • edited Loading

life2015 commented Mar 11, 2024 • edited Loading

life2015 commented May 29, 2024

life2015 commented May 30, 2024

codecov bot commented Jun 12, 2024 • edited Loading

Codecov Report

bytemain Jun 18, 2024

Choose a reason for hiding this comment

bytemain Jun 18, 2024

Choose a reason for hiding this comment

bytemain Jun 18, 2024

Choose a reason for hiding this comment

bytemain Jun 18, 2024

Choose a reason for hiding this comment

life2015 commented Mar 11, 2024 •

edited

Loading

erha19 commented Mar 11, 2024 •

edited

Loading

life2015 commented Mar 11, 2024 •

edited

Loading

codecov bot commented Jun 12, 2024 •

edited

Loading