fix: rerender select component if label changed (#2880)

opensumi · Jul 12, 2023 · 1361d0c · 1361d0c
1 parent 5fe93e5
commit 1361d0c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/preferences/src/browser/preferenceItem.view.tsx b/packages/preferences/src/browser/preferenceItem.view.tsx
@@ -526,7 +526,7 @@ function SelectPreferenceItem({
         </Option>
       );
     });
-  }, [schema.enum]);
+  }, [schema.enum, labels]);
 
   const renderNoneOptions = () => (
     <Option

diff --git a/packages/preferences/src/browser/preferences.view.tsx b/packages/preferences/src/browser/preferences.view.tsx
@@ -63,13 +63,11 @@ const usePreferenceGroups = () => {
     const dispose = preferenceService.onSettingsGroupsChange(() => {
       updateGroup.run();
     });
+    updateGroup.run();
+
     return () => {
       dispose.dispose();
     };
-  });
-
-  useEffect(() => {
-    updateGroup.run();
   }, []);
 
   useEffect(() => {