Revert "Grant access to support group during WifConfig creation" #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a39ce2e.
ckandag
approved these changes
Sep 13, 2024
JakobGray
reviewed
Sep 13, 2024
| WifConfig: wifConfig, | ||
| }) | ||
|
|
||
| if err := gcpClientWifConfigShim.GrantSupportAccess(ctx, log); err != nil { |
There was a problem hiding this comment.
Removing this line would be enough to resolve the issue until it can be properly addressed
ckandag
added a commit
that referenced
this pull request
Oct 15, 2024
-e034b6b Update Konflux references to 2418e94 -5066ea0 Filter wif configs in interactive mode (#660) -878f5e3 Initial refactor to prepare to move the connection builder and config packages to ocm-common -1ea2e05 lint -2c66dc0 removes redundant api url -65bf8cf Add role prefix flag on create wif-config (#662) -a39ce2e Grant access to support group during WifConfig creation (#663) -0275d67 Revert "Grant access to support group during WifConfig creation (#663)" (#664) -7cddc94 Wif creation improvements, including logic to grant support access as part of wif creation. (#666) -7f41626 Update Konflux references -b9a750c UpdatesToKonflux (#668) -e4aa770 OCM-10615 | Implement 'gcp wif-config update' command (#667) -cf6e500 Dry-run wif config delete before tearing down cloud resources (#670) -e18ea10 OCM-11842 | feat: Updates to support GCP-PSC clusters (#672) -893acd5 wif-enable gcp-inquiries (#673) -664b2c4 Replace wif dry-run flag with mode (#671) -df87894 Update Konflux references (#669)
Merged
renan-campos
pushed a commit
that referenced
this pull request
Oct 15, 2024
-e034b6b Update Konflux references to 2418e94 -5066ea0 Filter wif configs in interactive mode (#660) -878f5e3 Initial refactor to prepare to move the connection builder and config packages to ocm-common -1ea2e05 lint -2c66dc0 removes redundant api url -65bf8cf Add role prefix flag on create wif-config (#662) -a39ce2e Grant access to support group during WifConfig creation (#663) -0275d67 Revert "Grant access to support group during WifConfig creation (#663)" (#664) -7cddc94 Wif creation improvements, including logic to grant support access as part of wif creation. (#666) -7f41626 Update Konflux references -b9a750c UpdatesToKonflux (#668) -e4aa770 OCM-10615 | Implement 'gcp wif-config update' command (#667) -cf6e500 Dry-run wif config delete before tearing down cloud resources (#670) -e18ea10 OCM-11842 | feat: Updates to support GCP-PSC clusters (#672) -893acd5 wif-enable gcp-inquiries (#673) -664b2c4 Replace wif dry-run flag with mode (#671) -df87894 Update Konflux references (#669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced race-condition related errors. Role-binding is attempted before GCP has had a chance to fully register the service account created. This results in BadRequest errors and the need to create a new WifConfig call.