Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade detection during parallel recovery #789

Conversation

swoehrl-mw
Copy link
Collaborator

Description

Fixes a bug where parallel recovery did not engage if the cluster had gone through a version upgrade beforehand.
Reason was that the upgrade logic added the status for each nodepool twice leading to the recovery logic incorrectly detecting if an upgrade was in progress.
Also did a small refactoring of names and constants and fixed a warning by my IDE about unused parameters.

No changes to the CRDs or functionality, just internal logic fixes.

Issues Resolved

Fixes #730

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

If CRDs are changed:

  • [-] CRD YAMLs updated (make manifests) and also copied into the helm chart
  • [-] Changes to CRDs documented

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sebastian Woehrl <sebastian.woehrl@maibornwolff.de>
@prudhvigodithi
Copy link
Collaborator

Thanks @swoehrl-mw.

@swoehrl-mw swoehrl-mw merged commit 4f59766 into opensearch-project:main May 21, 2024
8 checks passed
@swoehrl-mw swoehrl-mw deleted the bugfix/upgrade-detection-recovery branch May 21, 2024 06:46
swoehrl-mw added a commit that referenced this pull request Jun 18, 2024
### Description
Fixes a bug where parallel recovery did not engage if the cluster had
gone through a version upgrade beforehand.
Reason was that the upgrade logic added the status for each nodepool
twice leading to the recovery logic incorrectly detecting if an upgrade
was in progress.
Also did a small refactoring of names and constants and fixed a warning
by my IDE about unused parameters.

No changes to the CRDs or functionality, just internal logic fixes.

### Issues Resolved
Fixes #730

### Check List
- [x] Commits are signed per the DCO using --signoff
- [x] Unittest added for the new/changed functionality and all unit
tests are successful
- [x] Customer-visible features documented
- [x] No linter warnings (`make lint`)

If CRDs are changed:
- [-] CRD YAMLs updated (`make manifests`) and also copied into the helm
chart
- [-] Changes to CRDs documented

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Sebastian Woehrl <sebastian.woehrl@maibornwolff.de>
(cherry picked from commit 4f59766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Parallel Cluster Recovery didn't work
2 participants