-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes OpenSearchISMPolicy crd kind in docs #741
Conversation
Minor typo fix for the OpenSearchISMPolicy kind Signed-off-by: Gustavo Andrade Ferreira <jojovembh@gmail.com>
I dont know what is the pattern for CRD naming, but they are using capital S in some and lower case in others:
|
I would vote for capital 'S' like in OpenSearchISMPolicy for all new CRDs, and then, with the next major release, change all the other CRDs to also be camel cased (as a breaking change). Wdyt @idanl21 @dbason @swoehrl-mw @prudhvigodithi @jochenkressin @pchmielnik |
I like the idea of using a capital 'S'. This approach promotes consistency and clarity in naming conventions, which is beneficial for long-term maintenance and usability. |
I would go for capital |
Should we push this change to |
This PR is only a doc change, in the code the capital S is already correct, so no breaking change. That also means it makes no difference if it is merged before or after the release. |
Thanks then can we go ahead with the PR? |
Minor typo fix for the OpenSearchISMPolicy kind
Description
Minor typo fix for the OpenSearchISMPolicy kind