-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opensearchcluster spec add Job resource config #683
opensearchcluster spec add Job resource config #683
Conversation
Hey @wangshulei098 thanks for your contribution, we can ship this, is it possible to add some unit tests, also please fix the conflicts. |
2785992
to
4aea38e
Compare
2f29aee
to
ba46d8f
Compare
Hey, The conflict has been resolved and the unit tests have been added, please approve to proceed,thanks |
Hi @wangshulei098 thanky you but I still see a confilct in "opensearch-operator/pkg/builders/cluster.go". Please re-base from main. |
…ntainer inherit the settings from Spec.InitHelper.Resource opensearchcluster spec add Job resource config and all initcontainer inherit the settings from Spec.InitHelper.Resource Signed-off-by: wangshulei098 <850732903@qq.com>
ba46d8f
to
bb41f65
Compare
Hey @salyh ,The conflict resulting from merging new commits has been resolved. Please approve at your earliest convenience,thanks |
This PR has overlap with #628, need to make sure they do not conflict and do not solve the same thing |
This PR resolves the issue of being unable to deploy applications, including initcontainers and some jobs, after setting resourcequotas. However, The PR associated with #628 fails to address this issue. |
add initcontainer resource and job config unit test Signed-off-by: wangshulei098 <850732903@qq.com>
As mentioned I'm ok to move forward with this unless @salyh @swoehrl-mw has any objections, @wangshulei098 can you update the readme with examples as well so folks understand and know |
bb41f65
to
a4f9555
Compare
Okay, I have updated the readme and added the feature of supporting namespace ResourceQuota. |
Thanks @wangshulei098. @salyh @swoehrl-mw need one more approval can you please check? |
Adding @salyh @swoehrl-mw @jochenkressin @pchmielnik to please check this PR. |
@salyh @swoehrl-mw @jochenkressin @pchmielnik please help to check this PR. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is overlap with #628 as both PRs configure resources for jobs.
628 has been merged, so please rebase and rework your PR to fit with what was done there.
Also:
- The changes to the CRDs have not been copied into the operator helm chart
- The new functionality has not been documented in the userguide
another pr has coverd all features of this PR。 close #678 |
add job config to support resourcequota
Description
Issues Resolved
Fixes #678