Account for asynchronous event generation in ol maps when synchronizing with the 2d map #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When paning and zooming the 3d map, the pitch (tilt) and the heading of the camera were continuosly adapted by small steps in an unpredictable way.
There is a guard flag in
Camera.updateView()which causes the events from the ol map to be ignored, while the ol map is adjusted. Unfortunately the ol map events are generated asynchronously and the guard flag was already reset right at the end ofCamera.updateView(). This was too early and so events would be handled which should have been ignored.