Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dashed lines #1026

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add support for dashed lines #1026

merged 1 commit into from
Feb 28, 2024

Conversation

fredj
Copy link
Member

@fredj fredj commented Apr 25, 2023

fixes #179

@fredj fredj force-pushed the polyline_dash branch 3 times, most recently from df66c64 to 63190e4 Compare April 26, 2023 07:32
@gberaudo
Copy link
Member

Hi @fredj, thanks for your initial work.
I reworked it only lightly to handle strange cases and add some documentation and unit tests.

fredj
fredj commented Feb 28, 2024
View reviewed changes
src/olcs/FeatureConverter.ts Outdated Show resolved Hide resolved
@fredj @gberaudo
Add support for dashed lines using PolylineDash
e2471d2 
- add tests;
- add allowSyntheticDefaultImports to allow loading node assert and test modules.
@gberaudo gberaudo merged commit eabac95 into master Feb 28, 2024
1 check passed
@gberaudo gberaudo deleted the polyline_dash branch February 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for dashed lines
2 participants
@fredj @gberaudo