Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements #550

Merged
merged 28 commits into from
Oct 16, 2024
Merged

Conversation

renatav
Copy link
Collaborator

@renatav renatav commented Oct 9, 2024

Description (e.g. "Related to ...", etc.)

Contains a number of fixes and usability improvements, mostly related to some recent work (like updates made to logging, creation of a configuration directory, automatically finding an authentication repository), as well as some create repo fixes and a couple of new features.
Adds a function for exporting keys-description.json based on the repository's current state. This is initial work towards storing this file in the repo's configuration directory and potentially using it to make operations like adding new roles or updating current ones easier.
Also contains work on handling more edge cases, catching more errors and cleaning up a repository after an error occurs.
Simplified two CLI commands by allowing specification of a custom file containing additional data. Determined that implementing < or | would require substantial rework, since we'd no longer be able to use prompts (which we rely on at the moment to ask the users to insert their yubikey, enter their pins securely etc.). I believe that this is a good compromise and that we shouldn't spend too much time on such a feature.
Added support for cloning a new dependency when adding it to dependencies.json if it is not on disk
Closes #536
Closes #531
Closes #526
Closes #347
See #497

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@renatav renatav force-pushed the renatav/usability-improvements branch from 7d57794 to 6aecb03 Compare October 9, 2024 23:46
@renatav renatav force-pushed the renatav/usability-improvements branch from aff9cea to 7c4a7c3 Compare October 16, 2024 01:20
@renatav renatav marked this pull request as ready for review October 16, 2024 22:26
@renatav renatav changed the title Usability improvements and a signing with yubikeys fix Usability improvements Oct 16, 2024
@renatav renatav force-pushed the renatav/usability-improvements branch from 5148057 to 4ebabf6 Compare October 16, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants