refact: Remove hosts #330
refact: Remove hosts #330
Conversation
Remove hosts handler. Now, instead of iterating through each host, we simply iterate through all updated repositories and update the dictionary response in update handler
Do not run host handler (since it is removed). Refactored `_check_update_status` to set update status and any error messages based on updated repositories (instead of hosts). Add minor type hints to function signatures Added `_update_transient_data` which updates the transient dictionary into it's own function. This code was earlier in a for loop.
Necessary since host handler is removed
There was a problem hiding this comment.
While I agree thwt hosts is not something that TAF necessarily needs to handle (TAF is not meant to be used for hosting purposes, so it being used to determine a host was probably an overkill), 2 questions:
Do we know what was causing the issue leading to the removal of this code? Was it not worth debugging it due to change of plans or was it difficult to debug? Was removal of host handler files not sufficient? If so, then I would definitely want to get to the bottom of it
|
I believe the reasoning was that rather than debugging (and getting to the bottom of the issue) we would just remove the host code, while having a reference to this PR so that we could reimplement the handler if it becomes necessary. So I think the reasoning was that it wasn't worth debugging because our thinking with stelae has been to not rely on hosts information. |
Description (e.g. "Related to ...", etc.)
Closes #328
Removed hosts and hosts.json logic. It was necessary to remove the host handler and omit the hosts from the pull pipeline schema. Removed hosts from documentation and from testing framework.
To test, run
taf repo update https://github.com/openlawlibrary/open-lawCode review checklist (for code reviewer to complete)