-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove vendor. #1554
chore: remove vendor. #1554
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 47.91% 48.03% +0.12%
==========================================
Files 162 162
Lines 23491 23491
==========================================
+ Hits 11256 11285 +29
+ Misses 11014 10995 -19
+ Partials 1221 1211 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@liangyuanpeng Can you fix the failed check. https://github.com/openkruise/kruise/actions/runs/8497215787/job/23287275816?pr=1554 |
Upgrades controller-gen from 0.11.0 to 0.14.0 to fix kubernetes-sigs/controller-tools#880, and this is resolved by #1562, so let's waiting for #1562 |
/hold |
/retest |
Signed-off-by: Lan Liang <gcslyp@gmail.com>
@zmberg PTAL Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@liangyuanpeng is the patch ready for merge? the patch is still labeled with "do-not-merge" label |
Absolutely,Thanks for remind. /hold cancel |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Fixes #1533
/assign @zmberg
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews