sync podCondition when probe message of probeStates changed #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisliu1995
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
+ Coverage 48.30% 48.40% +0.09%
==========================================
Files 154 157 +3
Lines 21667 22440 +773
==========================================
+ Hits 10467 10862 +395
- Misses 10048 10387 +339
- Partials 1152 1191 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chrisliu1995
force-pushed
the
probe_condition_sync
branch
from
c1d439f
to
b41a89a
Compare
chrisliu1995
force-pushed
the
probe_condition_sync
branch
3 times, most recently
from
62b41f4
to
b66bc55
Compare
chrisliu1995
force-pushed
the
probe_condition_sync
branch
from
b66bc55
to
6a1f618
Compare
Signed-off-by: ChrisLiu <chrisliu1995@163.com>
chrisliu1995
force-pushed
the
probe_condition_sync
branch
from
6a1f618
to
286f4c2
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
zmberg
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: ChrisLiu <chrisliu1995@163.com>
ppbits
pushed a commit
to ppbits/kruise
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
When the message corresponding to the probeStates of NodePodProbe changes, the pod Condition cannot obtain the latest message because the state remains unchanged.
Therefore, the pod Condition should also be updated when the probe message changed.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews