Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus for pub and deletion protection #1398

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Sep 1, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Sep 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #1398 (d2a98b7) into master (a477df8) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
- Coverage   48.25%   48.24%   -0.01%     
==========================================
  Files         152      153       +1     
  Lines       21469    21492      +23     
==========================================
+ Hits        10359    10369      +10     
- Misses       9973     9984      +11     
- Partials     1137     1139       +2     
Flag Coverage Δ
unittests 48.24% <72.72%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/controller/cloneset/sync/api.go 0.00% <ø> (ø)
pkg/controller/cloneset/sync/cloneset_update.go 57.72% <0.00%> (ø)
...neset/validating/cloneset_create_update_handler.go 0.00% <0.00%> (ø)
...ebhook/pod/validating/pod_create_update_handler.go 0.00% <ø> (ø)
...et/validating/statefulset_create_update_handler.go 0.00% <0.00%> (ø)
...lidating/uniteddeployment_create_update_handler.go 0.00% <0.00%> (ø)
pkg/control/pubcontrol/pub_control_utils.go 50.60% <60.00%> (-0.39%) ⬇️
pkg/control/pubcontrol/api.go 100.00% <100.00%> (ø)
pkg/control/pubcontrol/pub_control.go 27.02% <100.00%> (+2.02%) ⬆️
pkg/control/pubcontrol/pub_control_metrics.go 100.00% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -133,7 +129,7 @@ func (c *realControl) Update(cs *appsv1alpha1.CloneSet,
for _, idx := range waitUpdateIndexes {
pod := pods[idx]
// Determine the pub before updating the pod
if utilfeature.DefaultFeatureGate.Enabled(features.PodUnavailableBudgetUpdateGate) {
/*if utilfeature.DefaultFeatureGate.Enabled(features.PodUnavailableBudgetUpdateGate) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz comment why delete this code

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 2774109 into openkruise:master Sep 6, 2023
21 checks passed
@zmberg zmberg deleted the protection_metrics_v2 branch September 6, 2023 09:03
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants