Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming the kruise image to remove some non-essential commands #1397

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Aug 31, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@kruise-bot kruise-bot added the size/S size/S 10-29 label Aug 31, 2023
@zmberg zmberg changed the title Docker image ci Trimming the kruise image to remove some non-essential commands Aug 31, 2023
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1397 (6e38297) into master (b483f4a) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 6e38297 differs from pull request most recent head 604b741. Consider uploading reports for the commit 604b741 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
- Coverage   48.23%   48.21%   -0.02%     
==========================================
  Files         152      152              
  Lines       21469    21469              
==========================================
- Hits        10355    10351       -4     
- Misses       9976     9980       +4     
  Partials     1138     1138              
Flag Coverage Δ
unittests 48.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member Author

zmberg commented Sep 1, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit a477df8 into openkruise:master Sep 1, 2023
21 checks passed
@zmberg zmberg deleted the docker-image-ci branch September 1, 2023 01:50
lilongfeng0902 pushed a commit to lilongfeng0902/kruise that referenced this pull request Sep 12, 2023
…kruise#1397)

* wrokflow docker image ci

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

* Trimming the kruise image to remove some non-essential commands

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>

---------

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg added this to the 1.6 milestone Mar 7, 2024
ppbits pushed a commit to ppbits/kruise that referenced this pull request Apr 4, 2024
…kruise#1397)

* wrokflow docker image ci


* Trimming the kruise image to remove some non-essential commands


---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants