Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhanced in-place update module to support vertical scaling #1353

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+3,360 −66

merge into default handler and add uts/e2e

eea019c
Select commit
Loading
Failed to load commit list.
Open

feat: enhanced in-place update module to support vertical scaling #1353

merge into default handler and add uts/e2e
eea019c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 14, 2024 in 0s

49.40% (+1.49%) compared to 0d0031a

View this Pull Request on Codecov

49.40% (+1.49%) compared to 0d0031a

Details

Codecov Report

Attention: Patch coverage is 72.50000% with 55 lines in your changes missing coverage. Please review.

Project coverage is 49.40%. Comparing base (0d0031a) to head (eea019c).
Report is 85 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/inplaceupdate/inplace_update_defaults.go 77.00% 17 Missing and 6 partials ⚠️
pkg/util/inplaceupdate/inplace_update_vertical.go 76.74% 11 Missing and 9 partials ⚠️
pkg/controller/cloneset/core/cloneset_core.go 0.00% 6 Missing ⚠️
...kg/controller/cloneset/sync/cloneset_sync_utils.go 0.00% 3 Missing ⚠️
pkg/util/inplaceupdate/inplace_update.go 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
+ Coverage   47.91%   49.40%   +1.49%     
==========================================
  Files         162      192      +30     
  Lines       23491    19752    -3739     
==========================================
- Hits        11256     9759    -1497     
+ Misses      11014     8730    -2284     
- Partials     1221     1263      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov