Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enhanced livenessProbe solution #1161

Closed
wants to merge 1 commit into from

Conversation

BH4AWS
Copy link
Collaborator

@BH4AWS BH4AWS commented Jan 9, 2023

Ⅰ. Describe what this PR does

A new feature of the enhanced livenessProbe solution will be developed in Kruise. This PR is the detail proposal.

Ⅱ. Does this pull request fix one issue?

No, this is a new feature solution.

Ⅲ. Describe how to verify it

An enhanced livenessProbe solution is developed in the OpenKruise suite, where is compatible with the standard livenessProbe design in the Kubernetes OpenSource community, which fully considers the service availability when the application containers are restarting.

Ⅳ. Special notes for reviews

No.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @BH4AWS! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Jan 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #1161 (6a747e6) into master (53fb7e1) will increase coverage by 1.58%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1161      +/-   ##
==========================================
+ Coverage   49.73%   51.31%   +1.58%     
==========================================
  Files         137      149      +12     
  Lines       19331    22090    +2759     
==========================================
+ Hits         9614    11336    +1722     
- Misses       8667     9588     +921     
- Partials     1050     1166     +116     
Flag Coverage Δ
unittests 51.31% <ø> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 59 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stale
Copy link

stale bot commented Apr 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 9, 2023
@stale stale bot closed this Apr 17, 2023
@zmberg zmberg reopened this Apr 18, 2023
@stale stale bot removed the wontfix This will not be worked on label Apr 18, 2023
@stale
Copy link

stale bot commented Jul 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 17, 2023
@stale stale bot closed this Jul 24, 2023
@veophi
Copy link
Member

veophi commented Jul 24, 2023

/reopen

@kruise-bot
Copy link

@veophi: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kruise-bot kruise-bot reopened this Jul 24, 2023
@stale stale bot removed the wontfix This will not be worked on label Jul 24, 2023
@stale
Copy link

stale bot commented Oct 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 22, 2023
@stale stale bot closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants