SidecarSet inject sidecar container to all Pods in some namespaces

Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>

pkg/control/sidecarcontrol/util.go

@@ -103,6 +103,10 @@ func PodMatchedSidecarSet(c client.Client, pod *corev1.Pod, sidecarSet *appsv1al
 	if err != nil {
 		return false, err
 	}
+	// if no selector set, return ture
+	if selector.String() == "" {
+		return true, nil
+	}
 
 	if !selector.Empty() && selector.Matches(labels.Set(pod.Labels)) {
 		return true, nil

pkg/control/sidecarcontrol/util_test.go

@@ -1244,6 +1244,32 @@ func TestPodMatchedSidecarSet(t *testing.T) {
 			},
 			expect: false,
 		},
+		{
+			name: "test6",
+			getSidecarSet: func() *appsv1alpha1.SidecarSet {
+				demo := &appsv1alpha1.SidecarSet{
+					ObjectMeta: metav1.ObjectMeta{Name: "sidecarset-test"},
+					Spec: appsv1alpha1.SidecarSetSpec{
+						Namespace: "app1",
+					},
+				}
+				return demo
+			},
+			getPod: func() *corev1.Pod {
+				demo := &corev1.Pod{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      "test-pod",
+						Labels:    map[string]string{"app": "nginx"},
+						Namespace: "app1",
+					},
+				}
+				return demo
+			},
+			getNs: func() []*corev1.Namespace {
+				return nil
+			},
+			expect: true,
+		},
 	}
 
 	for _, cs := range cases {