Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6683: Mouse over for Event Thread should show the various thread IDs #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viragpurnam
Copy link
Collaborator

@viragpurnam viragpurnam commented Oct 18, 2024

Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view.

Before: No information on Hover
EventThread_Before

After: Thread Id shown on Hover
EventThread_After

Before: Only Thread Description shown in properties view
Properties_Before

After: Along with Thread Description, Thread Id also shown in properties view
Properties_After

Could you please review the changes? Please suggest if anything more is needed with this enhancement request.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-6683: Mouse over for Event Thread should show the various thread IDs (Enhancement - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/593/head:pull/593
$ git checkout pull/593

Update a local copy of the PR:
$ git checkout pull/593
$ git pull https://git.openjdk.org/jmc.git pull/593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 593

View PR using the GUI difftool:
$ git pr show -t 593

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/593.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

👋 Welcome back vpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Oct 18, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants