6683: Mouse over for Event Thread should show the various thread IDs #593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "Thread Id" information for Mouse Hover on Event Thread as well as in properties view.
Before: No information on Hover
After: Thread Id shown on Hover
Before: Only Thread Description shown in properties view
After: Along with Thread Description, Thread Id also shown in properties view
Could you please review the changes? Please suggest if anything more is needed with this enhancement request.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/593/head:pull/593
$ git checkout pull/593
Update a local copy of the PR:
$ git checkout pull/593
$ git pull https://git.openjdk.org/jmc.git pull/593/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 593
View PR using the GUI difftool:
$ git pr show -t 593
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/593.diff
Webrev
Link to Webrev Comment