Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated #2984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 22, 2024

I backport this for parity with 17.0.14-oracle.

Resolved because of indentation changes.
The list of further indented algorithms differs, further down one indentation was already fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301379 needs maintainer approval

Issue

  • JDK-8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2984/head:pull/2984
$ git checkout pull/2984

Update a local copy of the PR:
$ git checkout pull/2984
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2984

View PR using the GUI difftool:
$ git pr show -t 2984

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2984.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9f64a64376c677dbe1358807329b42737ac78ad9 8301379: Verify TLS_ECDH_* cipher suites cannot be negotiated Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 22, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant