Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MERGING RELEASE branches #37

Merged
merged 5 commits into from
Dec 6, 2023
Merged

MERGING RELEASE branches #37

merged 5 commits into from
Dec 6, 2023

Conversation

dragos-dobre
Copy link
Member 

        MERGING RELEASE branches
        Release release/23.10

lgtm-migrator and others added 5 commits November 7, 2022 16:19
@lgtm-migrator
Add CodeQL workflow for GitHub code scanning
9d8973e
@delcroip
fixes (#19)
5f1e435 
* OP-824: Fixed locations dry run
* OP-898: Add confirmation popup to XML upload
* OP-898: Remove unused variable
@edarchis
Merge pull request #17 from lgtm-migrator/codeql
ed2b162 
Add CodeQL workflow for GitHub code scanning
@dragos-dobre
Merge branch 'main' into release/23.04
2c1e40b
@dragos-dobre
Finish release/23.04
ce9b3df 
MERGING RELEASE branches
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 14, 2023
View reviewed changes
src/pages/ExtractsPage.js
@@ -16,6 +16,7 @@
import FeedbackIcon from "@material-ui/icons/SpeakerNotesOutlined";
import Block from "../components/Block";
import { RIGHT_EXTRACTS } from "../constants";
import {string} from "prop-types";

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused import string.
src/pages/RegistersPage.js
@@ -227,7 +225,7 @@
});
}
};

console.log("TOOLS RENDERING")

Check notice

Code scanning / CodeQL

Semicolon insertion Note

Avoid automated semicolon insertion (95% of all statements in
the enclosing function
Loading
have an explicit semicolon).
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@delcroip delcroip merged commit 8841deb into release/23.10 Dec 6, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dragos-dobre @delcroip @lgtm-migrator @edarchis