MR : #OICI-10 #OICI-9 #OICI-12 #OICI-13#OICI-15#OICI-14#OICI-17 #142
Conversation
…les details des familles
…insuree_js into feature-28211
Feature 28239
…insuree_js into feature-28509
…insuree_js into feature-28509
…insuree_js into feature-28515
Feature 28926
fix: correction on family form
Feature 29344
fix: correction on familytype
src/actions.js
Outdated
| "phone", | ||
| "healthFacility" + mm.getProjection("location.HealthFacilityPicker.projection"), | ||
| ]; | ||
| const FAMILY_HEAD_PROJECTION = |
There was a problem hiding this comment.
Be consistent with the definition of projection. Keep as in FAMILY_FULL_PROJECTION a list instead of a big string. Just add the missing part to the list so it will be easier to upgrade the module.
src/actions.js
Outdated
| "validityFrom", | ||
| "validityTo", | ||
| `headInsuree{${FAMILY_HEAD_PROJECTION(mm).join(",")}}`, | ||
| FAMILY_HEAD_PROJECTION, |
There was a problem hiding this comment.
Be consistent with the definition of projection.
src/actions.js
Outdated
| ` | ||
| } | ||
|
|
||
| export function formatUnlinFamily (familyUuids, cancelPolicies){ |
There was a problem hiding this comment.
Fix spelling formatUnlinkFamily
src/components/FamilyForm.js
Outdated
| @@ -213,7 +222,7 @@ class FamilyForm extends Component { | |||
| openFamilyButton={openFamilyButton} | |||
| overview={overview} | |||
| HeadPanel={FamilyMasterPanel} | |||
| Panels={overview ? [FamilyInsureesOverview] : [HeadInsureeMasterPanel]} | |||
| Panels={(overview && (!!family.familyType && family.familyType.code == 'P'))? [ HeadInsureeMasterPanel, SubFamiliesSummary] : overview &&(!!family.familyType && family.familyType.code !== 'P') ? [ FamilyInsureesOverview] : [HeadInsureeMasterPanel]} | |||
There was a problem hiding this comment.
Define 'P' as a constant to improve code reading.
src/components/FamilyMasterPanel.js
Outdated
| /> | ||
| </Grid>} | ||
|
|
||
| {/* <Grid item xs={2} className={classes.item}> |
There was a problem hiding this comment.
This should not be commented but hidden with a module configuration parameter.
There was a problem hiding this comment.
src/reducer.js
Outdated
| @@ -309,7 +364,7 @@ function reducer( | |||
| ...state, | |||
| fetchingFamilyTypes: false, | |||
| fetchedFamilyTypes: true, | |||
| familyTypes: action.payload.data.familyTypes.map((t) => t.code), | |||
| familyTypes: action.payload.data.familyTypes.filter(t => t.code !== 'C' && t.code !=='O').map((t) => t.code), | |||
There was a problem hiding this comment.
Make constants for C and O for code understanding.
src/reducer.js
Outdated
| @@ -398,7 +498,7 @@ function reducer( | |||
| ...state, | |||
| fetchingRelations: false, | |||
| fetchedRelations: true, | |||
| relations: action.payload.data.relations.map((p) => p.id), | |||
| relations: action.payload.data.relations.filter((p) => p.id !==10).map((p) => p.id), | |||
There was a problem hiding this comment.
What is 10? Create constant.
| "insuree.Profession.2": "Employee", | ||
| "insuree.Profession.3": "Self Employee", | ||
| "insuree.Profession.4": "Other", | ||
| "insuree.Profession.1": "Liberal", |
There was a problem hiding this comment.
These terms should be in the language pack.
There was a problem hiding this comment.
for comores RFC we have others option for profession fields options
src/utils/utils.js
Outdated
| (!!insuree.passport && (insuree.passport.length < PASSPORT_LENGTH || insuree.passport.length > PASSPORT_LENGTH)) | ||
| ) | ||
| return false; | ||
| if (!!insuree.preferredPaymentMethod && insuree.preferredPaymentMethod == "PB" && !insuree.bankCoordinates) |
There was a problem hiding this comment.
we created INSUREE_PREFERRED_PAYMENT_METHOD in constant.js
src/constants.js
Outdated
| @@ -23,7 +24,7 @@ export const RIGHT_INSUREE_ADD = 101102; | |||
| export const RIGHT_INSUREE_EDIT = 101103; | |||
| export const RIGHT_INSUREE_DELETE = 101104; | |||
| export const RIGHT_INSUREE_ENQUIRE = 101105; | |||
|
|
|||
| export const PASSPORT_LENGTH = 7 | |||
There was a problem hiding this comment.
We should be able to modify by module config.
Feature 29890
fix: correction sur le champs caché confirmationType
fix: correction Pr
review action.js
|
No description provided.