Use location cache all location #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
delcroip
reviewed
Oct 21, 2024
| districts = [] | ||
| if cachedata is None: | ||
| cachedata = [] | ||
| if user.is_superuser: | ||
| if user.is_superuser or LocationConfig.no_location_check: |
There was a problem hiding this comment.
we might create a specific cache for admin and when no location check to avoid filling the cache with the same data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new All Location Parameters to manage same districts cache for all users.
Some implementations are depoyed at a national scale (seeing all districts as claim admin / enrollement officier can see all insurees and claim in all districts), so caching information based on users as not so relevant.