Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error logging when sending the result via PendingIntent fails #1044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sheepmaster
Copy link

@sheepmaster sheepmaster commented Feb 14, 2024

Update the error message not to mention cancelling, as the sendResult() method is used for sending the completion intent as well, and also include the exception stack trace.

Checklist

  • I read the Contribution Guidelines
  • I signed the CLA and WG Agreements
  • I ran, updated and added unit tests as necessary.
  • I verified the contribution matches existing coding style.
  • I updated the documentation if necessary.

Motivation and Context

The sendResult() method is used for sending the completion intent as well as the cancellation intent, but its error message only mentions cancellation, which can be confusing. In addition, the additional exception parameter passed to Logger.error() is ignored.

Description

Update the error message not to mention cancelling, and also include the exception stack trace.

Update the error message not to mention cancelling, as the
`sendResult()` method is used for sending the completion intent as well,
and also include the exception stack trace.
@sheepmaster sheepmaster marked this pull request as ready for review February 28, 2024 15:16
@sheepmaster
Copy link
Author

Friendly ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant