Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix addon discovery XML not overwritten #1615

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Fix addon discovery XML not overwritten #1615

merged 1 commit into from
Dec 17, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Dec 17, 2023 •
edited
Loading

@J-N-K
Fix addon discovery XML not overwritten
8b668c7 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior label Dec 17, 2023
@J-N-K J-N-K requested a review from a team as a code owner December 17, 2023 16:47
mherwege
mherwege approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mherwege
Copy link
Contributor

@kaikreuzer This should fix the issue with old openhab-addon.xml files.

kaikreuzer
kaikreuzer approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit db211a5 into openhab:main Dec 17, 2023
3 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Dec 17, 2023
@J-N-K J-N-K deleted the fix-addon-overwerite branch December 17, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@mherwege mherwege mherwege approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @mherwege @kaikreuzer