feat: connect over tcp if initiator isn't rdma capable #875
+93
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharma-dc
requested review from
Abhinandan-Purkait,
tiagolobocastro,
sinhaashish and
abhilashshetty04
and removed request for
Abhinandan-Purkait
Abhinandan-Purkait
approved these changes
Oct 15, 2024
abhilashshetty04
approved these changes
Oct 15, 2024
dsharma-dc
force-pushed
the
connect_tcp_fallback
branch
3 times, most recently
from
53bf0a8
to
969ad17
Compare
tiagolobocastro
approved these changes
Oct 21, 2024
dsharma-dc
force-pushed
the
connect_tcp_fallback
branch
from
969ad17
to
d6a8c97
Compare
|
bors try |
tryBuild failed: |
CI failed with bors try |
|
bors try |
tryBuild failed: |
ok, not seeing the infra issue anymore, but this run failed at an unrelated(volume resize) test which is flaky it seems. bors try |
tryBuild succeeded: |
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
dsharma-dc
force-pushed
the
connect_tcp_fallback
branch
from
d6a8c97
to
56667fb
Compare
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
false. We can make this default true once tested thoroughly. have some setup limitations currently.