Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label attribute for Policer, RIF, Scheduler and UDF #2046

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erohsik
Copy link
Contributor

@erohsik erohsik commented Jul 10, 2024

Add label attribute to a few SAI objects that will help during warmboot object matching.

Add label attribute to a few SAI objects that will help during warmboot
object matching.

Signed-off-by: Kishore Gummadidala <kishorg@google.com>
Add label attribute to a few SAI objects that will help during warmboot
object matching.

Signed-off-by: Kishore Gummadidala <kishorg@google.com>
@kcudnik
Copy link
Collaborator

kcudnik commented Jul 24, 2024

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

@erohsik
Copy link
Contributor Author

erohsik commented Sep 19, 2024

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

As discussed in the community meeting, the string provides the option to use the key from the application/config db entry..

@rlhui rlhui added the reviewed PR is discussed in SAI Meeting label Sep 19, 2024
@rlhui
Copy link
Collaborator

rlhui commented Sep 19, 2024

@JaiOCP , @rck-innovium , please help review? thanks.

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 2, 2024

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

As discussed in the community meeting, the string provides the option to use the key from the application/config db entry..

what config db entry ? SAI don't have any idea about any config db entry

@tjchadaga
Copy link
Collaborator

@erohsik - could you please resolve branch conflicts?

@tjchadaga
Copy link
Collaborator

Does this needs to be a string ? Or it would be better to make this uint32 or 64? Maybe it's discussion for sai community meeting

As discussed in the community meeting, the string provides the option to use the key from the application/config db entry..

what config db entry ? SAI don't have any idea about any config db entry

@kcudnik - Since the label is populated from the application/NOS, the general consensus was that a string would be easier to manage. Is there a concern with using a string label?

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 25, 2024

ok, i got it now it's just a label, please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed PR is discussed in SAI Meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants