-
Notifications
You must be signed in to change notification settings - Fork 475
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prefix Compression feature addition to SAI
- Loading branch information
1 parent
18ba20f
commit d379320
Showing
8 changed files
with
813 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| # ACL BINCODE Field Matching | ||
| ------------------------------------------------------------------------------- | ||
| Title | ACL BINCODE Field Matching | ||
| -------------|----------------------------------------------------------------- | ||
| Authors | Nader Shinouda, Cisco | ||
| Status | In review | ||
| Type | Standards track | ||
| Created | 2024-07-01 - Initial Draft | ||
| SAI-Version | 1.14 | ||
| ------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| ## 1.0 Introduction ## | ||
|
|
||
| This spec enhances the existing ACL spec to add support for bincode field matching. Bincode is part of prefix compression, where an IP prefix is mapped to Bincode. | ||
|
|
||
| New table attributes allow setting a source and destination prefix compression tables on the creation of an ACL table. New field entry attributes allow for matching on a specific bincode from either the source or destionation prefix tables. | ||
|
|
||
| ## 2.0 Specification ## | ||
|
|
||
| New table attributes allow for setting both the source and destination prefix compression tables that will be used in field matching | ||
| ```c | ||
| /** | ||
| * @brief SRC BINCODE | ||
| * | ||
| * This key is dedicated to matching on a SRC BINCODE | ||
| * | ||
| * @type bool | ||
| * @flags CREATE_ONLY | ||
| * @default false | ||
| */ | ||
| SAI_ACL_TABLE_ATTR_FIELD_SRC_PREFIX_BINCODE | ||
|
|
||
| /** | ||
| * @brief DST BINCODE | ||
| * | ||
| * This key is dedicated to matching on a DST BINCODE | ||
| * | ||
| * @type bool | ||
| * @flags CREATE_ONLY | ||
| * @default false | ||
| */ | ||
| SAI_ACL_TABLE_ATTR_FIELD_DST_PREFIX_BINCODE | ||
|
|
||
| /** | ||
| * @brief SRC prefix Table Object ID | ||
| * | ||
| * An object pointer to a prefix table used for | ||
| * source prefix lookups | ||
| * | ||
| * @type sai_object_id_t | ||
| * @flags CREATE_ONLY | ||
| * @objects SAI_OBJECT_TYPE_PREFIX_COMPRESSION_TABLE | ||
| * @allownull true | ||
| * @default SAI_NULL_OBJECT_ID | ||
| */ | ||
| SAI_ACL_TABLE_ATTR_SRC_PREFIX_COMPRESSION_TABLE, | ||
|
|
||
| /** | ||
| * @brief DST prefix Table Object ID | ||
| * | ||
| * An object pointer to a prefix table used for | ||
| * destination prefix lookups | ||
| * | ||
| * @type sai_object_id_t | ||
| * @flags CREATE_ONLY | ||
| * @objects SAI_OBJECT_TYPE_PREFIX_COMPRESSION_TABLE | ||
| * @allownull true | ||
| * @default SAI_NULL_OBJECT_ID | ||
| */ | ||
| SAI_ACL_TABLE_ATTR_DST_PREFIX_COMPRESSION_TABLE, | ||
| ``` | ||
|
|
||
| New field entry attributes allow for lookups based on a bincode value. | ||
|
|
||
| ```c | ||
| /** | ||
| * @brief SRC BINCODE | ||
| * | ||
| * @type sai_acl_field_data_t sai_uint32_t | ||
| * @flags CREATE_AND_SET | ||
| * @default disabled | ||
| */ | ||
| SAI_ACL_ENTRY_ATTR_FIELD_SRC_PREFIX_BINCODE, | ||
|
|
||
| /** | ||
| * @brief DST BINCODE | ||
| * | ||
| * @type sai_acl_field_data_t sai_uint32_t | ||
| * @flags CREATE_AND_SET | ||
| * @default disabled | ||
| */ | ||
| SAI_ACL_ENTRY_ATTR_FIELD_DST_PREFIX_BINCODE, | ||
| ``` | ||
|
|
||
| ## 3.0 Examples ## | ||
|
|
||
| ```c | ||
| // Example: Create Prefix Compression Table | ||
| sai_attr_table_list[0].id = SAI_PREFIX_COMPRESSION_TABLE_ATTR_DEFAULT_ENTRY_BINCODE; | ||
| sai_attr_table_list[0].value.u32 = 9000; | ||
| attr_table_count = 1; | ||
|
|
||
| // Create SRC Prefix Table | ||
| sai_create_prefix_compression_table_fn( | ||
| &src_prefix_compression_table_id, | ||
| switch_id, | ||
| attr_table_count, | ||
| sai_attr_table_list); | ||
|
|
||
| // Example: Create Prefix Compression Entries | ||
| // IPV4 First Entry source prefix table | ||
| sai_prefix_compression_entry_t entry_v4_src_1; | ||
| entry_v4_src_1.switch_id = switch_id; | ||
| entry_v4_src_1.prefix_table_id = src_prefix_compression_table_id; | ||
| entry_v4_src_1.prefix.addr_family = SAI_IP_ADDR_FAMILY_IPV4; | ||
| entry_v4_src_1.prefix.addr.ipv4 = "1.1.1.1"; | ||
| entry_v4_src_1.prefix_mask.ipv4 = "255.255.255.0"; | ||
| sai_attr_list_src[1].id = SAI_PREFIX_COMPRESSION_ENTRY_ATTR_BINCODE; | ||
| sai_attr_list_src[1].value.u32 = 500; | ||
|
|
||
| entry_list_src = [entry_v4_src_1]; | ||
| entry_list_size = 1; | ||
| attr_count_src = 1; | ||
| sai_status_t bulk_status; | ||
|
|
||
| // Adding using bulk add | ||
| sai_bulk_create_prefix_compression_entry_fn( | ||
| entry_list_size, | ||
| entry_list_src, | ||
| attr_count_src, | ||
| sai_attr_list_src, | ||
| SAI_BULK_OP_ERROR_MODE_STOP_ON_ERROR, | ||
| bulk_status); | ||
|
|
||
| // Create ACL table | ||
| sai_table_attr_list[0].id = SAI_ACL_TABLE_ATTR_SRC_PREFIX_COMPRESSION_TABLE; | ||
| sai_table_attr_list[0].value.oid = src_prefix_compression_table_id; | ||
| sai_table_attr_count = 1; | ||
|
|
||
| sai_create_acl_table_fn( | ||
| &acl_table_id, | ||
| switch_id, | ||
| sai_table_attr_count, | ||
| sai_table_attr_list); | ||
|
|
||
| sai_entry_attr_list[0].id = SAI_ACL_ENTRY_ATTR_FIELD_SRC_PREFIX_BINCODE; | ||
| sai_attr_list[1].value.aclfield.enable = true; | ||
| sai_attr_list[1].value.aclfield.mask = 0xFFFFFF; | ||
| sai_attr_list[1].value.aclfield.data = 500; | ||
| sai_entry_attr_count = 1; | ||
|
|
||
| // Create an Entry to match on Bincode 1 | ||
| sai_create_acl_entry_fn( | ||
| &acl_entry_id, | ||
| switch_id, | ||
| sai_entry_attr_count, | ||
| sai_entry_attr_list); | ||
| ``` |
Oops, something went wrong.