Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap-filling multi-strain workflow #873

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

yseif
Copy link

@yseif yseif commented Jul 11, 2019

This function is a modified version of the existing gapfilling algorithm adapted to the multi-strain workflow.
In such workflows, strain-specific models are built through a reductionist approach with comparative genomics identifying absent metabolic genes and metabolic modeling identifying the corresponding absent metabolic reactions and pathways. A common step in this workflow is a resulting non-functional model which needs to be gapfilled. As such, this function allows the user to pass the list of absent genes and the base model, and returns the reactions to be gapfilled.

@gregmedlock
Copy link
Member

Not sure how others think here, but I think the application is a bit too narrow given how straightforward the process is to warrant a new function to maintain. There are certainly more than a couple users I am aware of that are working on comparative/phylogenetic modeling analyses along the lines you're proposing, but the workflows used to generate reconstructions across those studies aren't very uniform. The functions we add would need to be pretty comprehensive to help anyone, and we'd be helping relatively few people in that case.

What do others think?

@Midnighter
Copy link
Member

@yseif first of all thank you for the contribution!

I agree with Greg that this is another perfect example for a "cookbook" kind of contribution. Just that we don't have one yet. If there is a need for certain recipes in the community, then we could integrate it in the wiki or the documentation. @yseif I am thinking of something like the scipy cookbook. If you can see yourself starting something like that, I'm sure we find many more things to add.

On a technical note: Your PR seems to contain the same function twice? Also, please note that we use the numpydoc format for docstrings.

@cdiener cdiener added the cookbook Issues that could be converted to future entries in a cobrapy cookbook. label Mar 13, 2020
@Midnighter Midnighter added the stale The issue or pull request lacks activity. label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cookbook Issues that could be converted to future entries in a cobrapy cookbook. stale The issue or pull request lacks activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants