Fix new filters not being loaded #914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new table filter was added to Opencast, it would not show up in the filters dropdown unless the page cache was cleared. This should fix that. I legit do not understand why the code was the way it was before this commit. If a reviewer could enlighten me why the previous code makes sense that would be great, but personally I see no harm in fetching the respective table filters everytime we load a new table.
|
This pull request is deployed at test.admin-interface.opencast.org/914/2024-09-13_07-58-38/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #693.
When a new table filter was added to Opencast, it would not show up in the filters dropdown unless the page cache was cleared. This should fix that.
I legit do not understand why the code was the way it was before this commit. If a reviewer could enlighten me why the previous code makes sense that would be great, but personally I see no harm in fetching the respective table filters everytime we load a new table.