Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cranskhaft with aasdk next #18

Open
wants to merge 2 commits into
base: crankshaft-ng
Choose a base branch
from

Conversation

dicetrash
Copy link

Make opencardev/openauto work with opencardev/aasdk newdev


void AndroidAutoEntity::onVoiceSessionRequest(const aasdk::proto::messages::VoiceSessionRequest& request)
{
OPENAUTO_LOG(error) << "[AndroidAutoEntity] voice session request not implemented";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - I couldn't find anything that references "voice session" only video session and has more then just start and stop

@matt2005
Copy link

Does this pr compile for you? I've tried to compile it, but am getting the following error.


/home/pi/workspace/buildsystem/openauto/src/btservice/AndroidBluetoothServer.cpp:27:10: fatal error: aasdk_proto/WifiInfoRequestMessage.pb.h: No such file or directory
   27 | #include <aasdk_proto/WifiInfoRequestMessage.pb.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/btservice.dir/build.make:121: CMakeFiles/btservice.dir/src/btservice/AndroidBluetoothServer.cpp.o] Error 1

@matt2005 matt2005 self-assigned this Jun 20, 2023
@matt2005 matt2005 added bug Something isn't working enhancement New feature or request labels Jun 20, 2023
@matt2005 matt2005 mentioned this pull request Jun 20, 2023
@dicetrash
Copy link
Author

dicetrash commented Jun 23, 2023

My libaasdk.so was compiled off aasdk with newdev branch and then I added WifiInfoRequestMessage.proto back from master so yes it compiled .., I can add an MR opencardev/aasdk#20 to add the three deleted proto files back into aasdk, not familiar enough with the project to know why they where deleted. More info from aasdk maintainers would be good to see where they want to go with this. opencardev/aasdk@newdev...opencardev:aasdk:development is the stuff in develop branch that never made it to newdev

@matt2005
Copy link

I'll verify it builds and test it over the weekend

@Fabio3rs
Copy link

Fabio3rs commented Oct 1, 2023

I checked-out this pull request, and I needed to make the following edit to be able to compile:

diff --git a/src/autoapp/Projection/OMXVideoOutput.cpp b/src/autoapp/Projection/OMXVideoOutput.cpp
index f8f3808..6a46380 100644
--- a/src/autoapp/Projection/OMXVideoOutput.cpp
+++ b/src/autoapp/Projection/OMXVideoOutput.cpp
@@ -23,7 +23,7 @@ extern "C"
 #include <bcm_host.h>
 }
 
-#include <f1x/aasdk/Common/Data.hpp>
+#include <aasdk/Common/Data.hpp>
 #include <f1x/openauto/autoapp/Projection/OMXVideoOutput.hpp>
 #include <f1x/openauto/Common/Log.hpp>
 

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems you have tried to use a different libgps version than what was previously used. is this intentional?
You seem to have resolved the resulting problems but someone really should write down the versions used for compilation (or at least the distro version!)
From what I can tell the original working version is libgps-dev=3.17-5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants