Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periodically close open request.Sessions to avoid buggy interaction with Docker Desktop #478

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Periodically close open request.Sessions to avoid buggy interaction with Docker Desktop #478

merged 2 commits into from
Jun 6, 2023

Commits on Jun 5, 2023

  1. Periodically refresh open requests.Sessions to mitigate open fileha… 

    …ndle issues (#179)

As reported from the field - we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open
file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server.
See #140 for more info.
    @jhallard
    jhallard committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    e174d60 View commit details
    Browse the repository at this point in the history

  2. [EZ] Remove sort-by-key when rendering JSON responses (#178) 

    * [EZ] Remove sort-by-key when rendering JSON responses

The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort
of response keys

* [EZ] Add unit test for new case

* Lint/fmt fixes

* Bleh isort

* Remove `internal_metrics` field
    @jhallard
    jhallard committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4048f15 View commit details
    Browse the repository at this point in the history