Restore views for Admin::EventsController#new, Admin::UsersController#edit
#3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AndrewKvalheim
force-pushed
the
restore-views
branch
2 times, most recently
from
cf06048
to
e00eecc
Compare
hennevogel
approved these changes
Apr 19, 2023
Lost during 81853d1
In openSUSE#2987 the detailed view of the event form was inadvertently lost, presumably due to openSUSE#2975 masking the problem.
Fails with:
1) User admin behaves like admin ability edits a user
Failure/Error: raise ActionController::MissingExactTemplate, message
ActionController::MissingExactTemplate:
Admin::UsersController#edit is missing a template for request formats: text/html
re openSUSE#2975
Fails with:
1) Event as an conference organizer create a proposal
Failure/Error: raise ActionController::MissingExactTemplate, message
ActionController::MissingExactTemplate:
Admin::EventsController#new is missing a template for request formats: text/html
re openSUSE#2975
…ler#edit 1. Restore views lost during 81853d1: git restore --source 4a16836 \ app/views/admin/users/_form.html.haml \ app/views/application/edit.html.haml \ app/views/application/new.html.haml mv app/views/application/edit.html.haml app/views/admin/users/ mv app/views/application/new.html.haml app/views/admin/events/ 2. Convert from Formtastic: - app/views/admin/users/_form.html.haml 3. Add header as in 81853d1: - app/views/admin/events/new.html.haml 4. Substitute partial unified in 88b5596: - app/views/admin/events/new.html.haml resolves openSUSE#2975
AndrewKvalheim
force-pushed
the
restore-views
branch
from
e00eecc
to
3ae1275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterbranch.Short description of what this resolves
#2975
Changes proposed in this pull request
While #3073 and #3092 also attempt to solve this issue, both introduce UI changes that are out of scope of the task of merely undoing the inadvertent deletion. I suggest that the forms first be restored to their original condition and then the remaining UI changes be discussed in their respective issues.
3bbbdb4)e00eecc)