Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AtomicI64, AtomicU64 for build mipsel processor #2054

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TGLuong
Copy link

@TGLuong TGLuong commented Aug 26, 2024

Changes

Use atomic_shim for mipsel processor. Because when build for mipsel architecture, it don't have AtomicI64, AtomicU64 in std.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@TGLuong TGLuong requested a review from a team August 26, 2024 04:48
Copy link

linux-foundation-easycla bot commented Aug 26, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.3%. Comparing base (b24bb9c) to head (f86b47e).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2054   +/-   ##
=====================================
  Coverage   77.3%   77.3%           
=====================================
  Files        124     124           
  Lines      21282   21282           
=====================================
  Hits       16472   16472           
  Misses      4810    4810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented Aug 26, 2024

Thanks for the PR. Couple of comments for now:

  1. any reason for using atomic_shim instead of portable-atomic ? Haven't used either of them, but from the stats (number of downloads and dependents), the later seems to be more widely used.
  2. Can we include this crate only when compiling for MIPS (and possibly PowerPC), as done here - https://github.com/esp-rs/rust/blob/1b259e0b8b2129dd3d62819a32f6d9b287e6b86c/compiler/rustc_data_structures/Cargo.toml#L50

@TGLuong
Copy link
Author

TGLuong commented Aug 26, 2024

Thanks for the PR. Couple of comments for now:

  1. any reason for using atomic_shim instead of portable-atomic ? Haven't used either of them, but from the stats (number of downloads and dependents), the later seems to be more widely used.
  2. Can we include this crate only when compiling for MIPS (and possibly PowerPC), as done here - https://github.com/esp-rs/rust/blob/1b259e0b8b2129dd3d62819a32f6d9b287e6b86c/compiler/rustc_data_structures/Cargo.toml#L50

Hi @lalitb, thanks for your comments:

  1. I search for Atomic library and only seen atomic_shim. I just have check portable-atomic and it seem to be better.
  2. Let me change to use this crate only for MIPS and PowerPC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants