DDR5 support: fix DIMM, memport numbering #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the indexing for memport and DIMMs Signed-off-by: Aravind T Nair <aravindnair@in.ibm.com>
devenrao
approved these changes
Oct 9, 2023
devenrao
approved these changes
Oct 9, 2023
dcrowell77
approved these changes
Oct 9, 2023
RameshIyyar
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Did you make sure that the index property of the non-DDR5 systems memport and dimm target index value matched? I think the FAPI_POS attribute value is not a relative index within one processor.
If the index is not matching then, there is a chance that the guard record or persisted info (device tree) will cause an issue i.e. it may pick the wrong target...
The index property which is used for the pdbg backend, expects the value should be "relative within its parent node to pull the respective target".
deepakala-k
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the indexing for memport and DIMMs