Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dlpar and LPM Documentation #659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harihare
Copy link
Collaborator

@harihare harihare commented Nov 1, 2021

Added Document with conf file example and command to run the
tests.

Signed-off-by: Hariharan T.S harihare@in.ibm.com

Added Document with conf file example and command to run the
tests.

Signed-off-by: Hariharan T.S <harihare@in.ibm.com>
@abdhaleegit
Copy link
Collaborator

@harihare adding conf to each testcase looks absured, can we have one Readme in testcases/ folder explaining the howtos ? just a thought to simplify things

@harihare
Copy link
Collaborator Author

harihare commented Nov 2, 2021

@harihare adding conf to each testcase looks absured, can we have one Readme in testcases/ folder explaining the howtos ? just a thought to simplify things

As for as I know this data is not required. Once any one start running the test, they will come to know how to wirte config and run the tests. As this point was discussed in KT and it will be the common place for all to have a look, we decided to add it in code.

@PraveenPenguin
Copy link
Collaborator

@harihare adding conf to each testcase looks absured, can we have one Readme in testcases/ folder explaining the howtos ? just a thought to simplify things

As for as I know this data is not required. Once any one start running the test, they will come to know how to wirte config and run the tests. As this point was discussed in KT and it will be the common place for all to have a look, we decided to add it in code.

it tricky here as flooding code with config does not seem me a good idea my vote on having a folder and have added common used config and even some test cases which require more argument we can have that config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants