-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix polygons not clearing #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMacenski
approved these changes
Aug 19, 2024
Marc-Morcos
added a commit
to Marc-Morcos/opennav_coverage
that referenced
this pull request
Aug 19, 2024
* Add behavior tree to navigate to start before starting fields navigation * snake case * comments * rviz visualization for demo * Update rviz_config.rviz * Linting and add to other demo * Fix polygons not clearing, credit to tonynajjar --------- Co-authored-by: Marc Morcos <30278842+MarcM0@users.noreply.github.com>
Marc-Morcos
added a commit
to Marc-Morcos/opennav_coverage
that referenced
this pull request
Aug 19, 2024
* Add behavior tree to navigate to start before starting fields navigation * snake case * comments * rviz visualization for demo * Update rviz_config.rviz * Linting and add to other demo * Fix polygons not clearing, credit to tonynajjar --------- Co-authored-by: Marc Morcos <30278842+MarcM0@users.noreply.github.com>
Merged
SteveMacenski
pushed a commit
that referenced
this pull request
Aug 19, 2024
* Fix polygons not clearing (#72) * Add behavior tree to navigate to start before starting fields navigation * snake case * comments * rviz visualization for demo * Update rviz_config.rviz * Linting and add to other demo * Fix polygons not clearing, credit to tonynajjar --------- Co-authored-by: Marc Morcos <30278842+MarcM0@users.noreply.github.com> * Rviz Visualization Config (#67) * Add behavior tree to navigate to start before starting fields navigation * snake case * comments * rviz visualization for demo * Update rviz_config.rviz * Linting and add to other demo * Add behavior tree to navigate to start before starting fields navigation (#65) * Add behavior tree to navigate to start before starting fields navigation * snake case * comments * Old format for behavior tree --------- Co-authored-by: Marc Morcos <30278842+MarcM0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polygons not clearing between requests.
See issue #71
This code was part of @tonynajjar 's pull request, this fix just needed to be done on a faster time scale: #43