Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI 4.1: add support for memory-alloc-kinds #1

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

hppritcha
Copy link
Member

@hppritcha hppritcha commented May 6, 2024

MPI 4.1: add support for memory-alloc-kinds
Changes will need to be made to Open MPI to parse the contents of
the OMPI_MCA_mpi_memory_alloc_kinds environment variable to
determine how to use the user supplied memory-alloc-kinds information.

See section 11.4.3 of the MPI 4.1 standard.

Signed-off-by: Howard Pritchard howardp@lanl.gov
(cherry picked from commit c5953e1)

@janjust
Copy link

janjust commented May 7, 2024

Probably need to add CI. At the very least github actions.
And maybe a description about this PR since it was discussed at the dev. meeting?

@hppritcha
Copy link
Member Author

i'll open a separate pr to add some of the upstream ci sanity checks then rebase this one. the description is a little light because its to commits. I'll fix that up.

@hppritcha hppritcha changed the title Add memory alloc kinds MPI 4.1: add support for memory-alloc-kinds May 7, 2024
@naughtont3
Copy link

@hppritcha Quick sanity check looked good. Also, skimmed MPI-4.1 and do not recall how we intended to reflect valid values that can be passed here. Added complication being that mpirun --help just tells us to look at mpirun(1).

@rhc54
Copy link

rhc54 commented May 14, 2024

FWIW: I found a few in one doc: system,mpi,rocm:device. No idea what the complete list looks like - if someone can pass it along, I can add to the help output.

Add a new cmd line option that corresponds to this
attribute. Add the attribute to the prun payload.
When received, it will default to including in the
job info for the spawned job. Add query support for it.

Signed-off-by: Ralph Castain <rhc@pmix.org>
(cherry picked from commit 3957789)
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8ee4753: MPI 4.1: add support for memory-alloc-kinds

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: c5953e1

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

Changes will need to be made to Open MPI to parse the contents of
the OMPI_MCA_mpi_memory_alloc_kinds environment variable to
determine how to use the user supplied memory-alloc-kinds information.

See section 11.4.3 of the MPI 4.1 standard.

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@hppritcha hppritcha merged commit cf0bf17 into open-mpi:master Jul 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants