Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scraper cleanup updates: added type annotation, logging, doc strings, and error handling #141

Merged
merged 12 commits into from
Oct 6, 2024
Merged

Scraper cleanup updates: added type annotation, logging, doc strings, and error handling #141

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
734e7a2
adding logging, typing, error handling to scraper
nicolassaw Sep 14, 2024
f985d84
scraper: logging, typeing, error handling part 2
nicolassaw Sep 14, 2024
88b40fa
final adding logging, typing, error handling to scraper
nicolassaw Sep 14, 2024
2433364
lowercase JO_id
nicolassaw Sep 21, 2024
d639fae
lowercase Dict[str, str]
nicolassaw Sep 21, 2024
71e35a3
Merge branch 'main' into scraper-cleanup-updates
nicolassaw Sep 21, 2024
f813355
lowercasing jo_id everywhere
nicolassaw Sep 21, 2024
f02495a
making ssl parameter and setting default true
nicolassaw Sep 22, 2024
9279ef6
making case_html_path an optional parameter
nicolassaw Sep 22, 2024
e569d6a
scraper: reformatting doc strings
nicolassaw Sep 22, 2024
b2849f1
scrpr cleanup: responding to code review comments
nicolassaw Sep 22, 2024
93c0c72
Merge branch 'main' into scraper-cleanup-updates
nicolassaw Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading