-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CCF Specification 1.0 #7
Open
fxamacker
wants to merge
11
commits into
main
Choose a base branch
from
fxamacker/update-ccf-specs-for-1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Update copyright for Flow Foundation. - Removed "Status: RC3" - Added "Version: 1.0.0" and removed "Revision". - Update "Scope" to highlight some scope-related items earlier: - Some requirements are explicitly defined as optional. - CCF-based formats or protocols MUST specify when optional requirements are used. - "Deterministic CCF Encoding Requirements" is optional so individual formats and protocols MUST specify when to use it (as previously stated deeper in this document).
This update corresponds to Cadence PR 3107: onflow/cadence#3107 This change does not affect CCF Codec because it was already implemented and deployed in the codec.
turbolent
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This update corresponds to Cadence PR 3131: onflow/cadence#3131 This change does not affect CCF Codec because it was already implemented and deployed in the codec.
This update corresponds to Cadence PR 2581: onflow/cadence#2581
fxamacker
changed the title
Update copyright and scope in ccf_specs.md
Update to CCF Specification 1.0
Oct 23, 2024
6 tasks
This update corresponds to Cadence PR 2523 and subsequent changes to inclusiverange and inclusiverange-type: onflow/cadence#2523 This change does not affect CCF Codec because it was already implemented and deployed in CCF codec.
This update corresponds to Cadence PR 3139: onflow/cadence#3139 This change does not affect CCF Codec because it was already implemented and deployed in CCF codec.
This change does not affect CCF Codec because it was already implemented and deployed in CCF codec.
6 tasks
This change does not affect CCF Codec because it was already removed (deprecated) and deployed in CCF codec.
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CCF Specs to version 1.0 and matches the deployed version of CCF Codec.
Primarily, this PR adds new Cadence types and other updates to match changes in Cadence:
FunctionType.Purity
in CCF codec cadence#3107ReferenceType.Authorization
) to CCF codec cadence#3139Other changes in this PR:
Note
Scope of specs hasn't changed because the added text only highlights what is stated deeper inside the document.