Update contracts-compatibility-checker #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 1662018 Collapsed results for better readability
|
SupunS
force-pushed
the
supun/update-contracts-checker
branch
from
18d0e6d
to
100508f
Compare
SupunS
force-pushed
the
supun/update-contracts-checker
branch
from
100508f
to
f52a7ed
Compare
SupunS
commented
Oct 18, 2024
SupunS
force-pushed
the
supun/update-contracts-checker
branch
from
0d1172f
to
cfd6412
Compare
SupunS
force-pushed
the
supun/update-contracts-checker
branch
from
871780e
to
8408a3f
Compare
|
CI check (https://github.com/onflow/cadence/actions/runs/11448933364/job/31853489202?pr=3631), is failing at "checking contracts using master" step because the tool's code on master is outdated, due to the changes of this PR. But the workflow passes for "checking contracts using head of the PR" (as expected), and the |
SupunS
changed the title
turbolent
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on onflow/flow-go#6571
Description
For each PR, the contracts backward-compatibility checker runs with the latest changes (~HEAD). The CI always replace the dependency to be the latest, however, if the tool wasn't updated to the latest cadence changes, then it is only caught at the time of CI.
Therefore, make the tool to always use the latest cadence, so any changes that would break the tool is caught locally, when running the tests.
masterbranchFiles changedin the Github PR explorer