PoC: WebAssembly API #2760

turbolent · 2023-09-01T17:37:06Z

Work towards #2853

Description

This PoC explores the idea of adding a WebAssembly API to Cadence, i.e. exposing a WebAssembly VM to Cadence programs.

The PRs adds:

A WebAssembly contract with an API inspired by the WebAssembly JavaScript Interface. The beginnings of the API support module instantiation, without imports, and access to function exports with i32 and i64 types.
An implementation of the WebAssembly API based on wasmtime. The VM has been configured with some reasonable settings and limits, but need to be refined.
A test case which demonstrates loading a simple add (i32, i32) -> i32 function, calling it with Cadence UInt32 values, and getting back the result as a Cadence UInt32.

https://github.com/onflow/cadence/pull/2760/files#diff-27b18491bc5b8a8ea5aabf7d9453695aef776c0858db4c84eea0963717c296b5R201-R216

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

allow instantiating a module without imports and allow access to function exports

github-actions · 2023-09-01T20:42:23Z

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 4a2d406
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
DecodeBatchEventsCCF-4	126ms ± 0%	125ms ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	369ms ± 0%	372ms ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	2.75µs ± 0%	2.75µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-4	2.03µs ± 0%	2.06µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	2.69µs ± 0%	3.26µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.02µs ± 0%	3.05µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	2.08µs ± 0%	2.12µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	2.39µs ± 0%	2.46µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-4	2.45µs ± 0%	2.51µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	2.38µs ± 0%	2.44µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-4	2.03µs ± 0%	2.05µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-4	2.56µs ± 0%	2.56µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-4	9.28µs ± 0%	9.36µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-4	5.42µs ± 0%	5.49µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	8.56µs ± 0%	8.63µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	11.4µs ± 0%	11.6µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	5.36µs ± 0%	5.49µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	6.81µs ± 0%	7.13µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-4	7.24µs ± 0%	7.36µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	6.49µs ± 0%	6.60µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-4	5.37µs ± 0%	5.37µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-4	7.28µs ± 0%	7.40µs ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsCCF-4	83.3ms ± 0%	82.5ms ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	102ms ± 0%	100ms ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	2.00µs ± 0%	1.85µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.49µs ± 0%	1.49µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.77µs ± 0%	1.83µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.06µs ± 0%	2.11µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.50µs ± 0%	1.50µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.61µs ± 0%	1.62µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	1.72µs ± 0%	1.67µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.68µs ± 0%	1.64µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.47µs ± 0%	1.47µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.69µs ± 0%	1.67µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	2.38µs ± 0%	2.37µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	1.36µs ± 0%	1.36µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	2.12µs ± 0%	2.21µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.87µs ± 0%	3.00µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	1.39µs ± 0%	1.40µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	1.77µs ± 0%	1.81µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	2.03µs ± 0%	2.07µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	1.62µs ± 0%	1.64µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	1.36µs ± 0%	1.36µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	2.01µs ± 0%	2.03µs ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	258ns ± 0%	270ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	76.9ns ± 0%	76.8ns ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	1.88ms ± 0%	1.86ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	847ns ± 0%	868ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	357ns ± 0%	359ns ± 0%	~	(p=1.000 n=1+1)
ParseArray-4	5.94ms ± 1%	6.09ms ± 0%	~	(p=0.333 n=2+2)
ParseDeploy/byte_array-4	9.45ms ± 2%	9.34ms ± 2%	~	(p=0.667 n=2+2)
ParseDeploy/decode_hex-4	978µs ± 0%	985µs ± 0%	~	(p=0.333 n=2+2)
ParseFungibleToken/With_memory_metering-4	150µs ± 2%	151µs ± 3%	~	(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4	116µs ± 3%	119µs ± 3%	~	(p=0.667 n=2+2)
ParseInfix-4	5.21µs ± 1%	5.49µs ± 4%	~	(p=0.333 n=2+2)
QualifiedIdentifierCreation/One_level-4	2.17ns ± 0%	2.17ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	80.5ns ± 0%	81.9ns ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	605µs ± 0%	608µs ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.71µs ± 0%	3.66µs ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/arrays-4	249ns ± 0%	249ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	90.8ns ± 0%	91.0ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	297ns ± 0%	298ns ± 0%	~	(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-4	68.6ns ± 0%	65.3ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
DecodeBatchEventsCCF-4	66.5MB ± 0%	66.5MB ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	242MB ± 0%	242MB ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	1.40kB ± 0%	1.40kB ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.48kB ± 0%	1.48kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.49kB ± 0%	1.49kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.26kB ± 0%	1.26kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	1.32kB ± 0%	1.32kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.30kB ± 0%	1.30kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	1.21kB ± 0%	1.21kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	1.33kB ± 0%	1.33kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	5.95kB ± 0%	5.95kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	3.55kB ± 0%	3.55kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	5.38kB ± 0%	5.38kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	7.30kB ± 0%	7.30kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	3.59kB ± 0%	3.59kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	4.49kB ± 0%	4.49kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	4.83kB ± 0%	4.83kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	4.41kB ± 0%	4.41kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	3.55kB ± 0%	3.55kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	4.83kB ± 0%	4.83kB ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	63.9MB ± 0%	63.9MB ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	40.7MB ± 0%	40.7MB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.47kB ± 0%	1.47kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.44kB ± 0%	1.44kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.38kB ± 0%	1.38kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.46kB ± 0%	1.46kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.23kB ± 0%	1.23kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	896B ± 0%	896B ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	536B ± 0%	536B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	920B ± 0%	920B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.11kB ± 0%	1.11kB ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	584B ± 0%	584B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	784B ± 0%	784B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	808B ± 0%	808B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	672B ± 0%	672B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	544B ± 0%	544B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	800B ± 0%	800B ± 0%	~	(all equal)
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	960B ± 0%	976B ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-4	2.69MB ± 0%	2.69MB ± 0%	~	(p=0.333 n=2+2)
ParseDeploy/byte_array-4	4.13MB ± 2%	4.13MB ± 2%	~	(p=1.000 n=2+2)
ParseDeploy/decode_hex-4	214kB ± 0%	214kB ± 0%	~	(p=0.667 n=2+2)
ParseFungibleToken/With_memory_metering-4	30.2kB ± 0%	30.2kB ± 0%	~	(p=0.667 n=2+2)
ParseFungibleToken/Without_memory_metering-4	30.2kB ± 0%	30.2kB ± 0%	~	(p=1.000 n=2+2)
ParseInfix-4	1.92kB ± 0%	1.92kB ± 0%	~	(p=0.667 n=2+2)
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	166kB ± 0%	165kB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	3.36kB ± 0%	3.36kB ± 0%	~	(all equal)
SuperTypeInference/arrays-4	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
DecodeBatchEventsCCF-4	1.48M ± 0%	1.48M ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	4.60M ± 0%	4.60M ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	124 ± 0%	124 ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	69.0 ± 0%	69.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	100 ± 0%	100 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	157 ± 0%	157 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	68.0 ± 0%	68.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	85.0 ± 0%	85.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	93.0 ± 0%	93.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	84.0 ± 0%	84.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	69.0 ± 0%	69.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	93.0 ± 0%	93.0 ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	1.00M ± 0%	1.00M ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	902k ± 0%	902k ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	17.0 ± 0%	17.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	14.0 ± 0%	14.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
InterpretRecursionFib-4	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-4	59.6k ± 0%	59.6k ± 0%	~	(p=0.667 n=2+2)
ParseDeploy/byte_array-4	89.4k ± 0%	89.4k ± 0%	~	(p=1.000 n=2+2)
ParseDeploy/decode_hex-4	63.0 ± 0%	63.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseFungibleToken/Without_memory_metering-4	773 ± 1%	773 ± 1%	~	(p=1.000 n=2+2)
ParseInfix-4	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	3.22k ± 0%	3.22k ± 0%	~	(all equal)
RuntimeScriptNoop-4	50.0 ± 0%	50.0 ± 0%	~	(all equal)
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

codecov · 2023-09-01T20:46:40Z

Codecov Report

Attention: Patch coverage is 79.34272% with 88 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (aeef038) to head (12b56a5).

❗ Current head 12b56a5 differs from pull request most recent head e55b81e

Please upload reports for the commit e55b81e to get more accurate results.

Files	Patch %	Lines
runtime/webassembly.go	70.10%	45 Missing and 10 partials ⚠️
runtime/stdlib/webassembly.go	80.16%	16 Missing and 8 partials ⚠️
runtime/repl.go	0.00%	4 Missing ⚠️
runtime/environment.go	83.33%	2 Missing and 1 partial ⚠️
runtime/common/computationkind_string.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
- Coverage   80.33%   80.33%   -0.01%     
==========================================
  Files         390      393       +3     
  Lines       95921    96338     +417     
==========================================
+ Hits        77060    77390     +330     
- Misses      16138    16206      +68     
- Partials     2723     2742      +19

Flag	Coverage Δ
unittests	`80.33% <79.34%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

runtime/webassembly_test.go

PratikDhanave · 2023-09-25T13:35:29Z

hi @turbolent thank you for adding a WebAssembly API to Cadence.
I want to know that next task would exposing wasmtime type table ?

darkdrag00nv2 · 2024-01-03T17:33:29Z

~~@turbolent Would it be possible to merge this into a feature branch? It'll allow me to open future PRs targeted on that branch.~~

Ah ignore, it is already on a feature branch. I didn't notice it.

runtime/stdlib/webassembly.cdc

…standard library

bytecodealliance/wasmtime-go#222

turbolent added 4 commits August 31, 2023 15:29

add support for dictionary types

2b7c365

update wasmtime

9fdfb4d

improve encodeArgs helper

cbc1ece

add the start of a WebAssembly contract

a780497

allow instantiating a module without imports and allow access to function exports

turbolent added the Feature label Sep 1, 2023

turbolent requested review from SupunS and dsainati1 as code owners September 1, 2023 17:37

turbolent self-assigned this Sep 1, 2023

turbolent marked this pull request as draft September 1, 2023 17:46

Base automatically changed from bastian/type-code-generator-for-stdlib to feature/stable-cadence September 1, 2023 20:29

Merge branch 'feature/stable-cadence' into bastian/webassembly

188b162

turbolent commented Sep 1, 2023

View reviewed changes

runtime/webassembly_test.go Outdated Show resolved Hide resolved

turbolent commented Sep 1, 2023

View reviewed changes

runtime/webassembly_test.go Show resolved Hide resolved

turbolent mentioned this pull request Sep 22, 2023

Add support for injecting types into the environment #2811

Merged

6 tasks

turbolent added 11 commits September 22, 2023 15:35

add comment explaining the program

02a0122

convert type

8d9cbb6

Merge branch 'feature/stable-cadence' into bastian/webassembly

254cb3d

Merge branch 'bastian/allow-type-injection' into bastian/webassembly

eaaf1ea

inject WebAssembly standard library type into environment

d4265f6

gate WebAssembly behind feture flag

384eef2

move wasmtime-based WebAssembly module to runtime, so it can be reused

4240bf9

rename

57b8d6a

extract constructor for wasmtime-based WebAssembly module

8d30d3a

add metering using fuel mechanism

606c3a2

fix return type conversion

a6e7b9a

turbolent mentioned this pull request Oct 5, 2023

Add a WebAssembly API #2853

Open

Merge branch 'bastian/sync-stable-cadence-10' into bastian/webassembly

f54b831

darkdrag00nv2 reviewed Mar 3, 2024

View reviewed changes

runtime/stdlib/webassembly.cdc Outdated Show resolved Hide resolved

turbolent added 28 commits March 3, 2024 10:35

update comment to reflect current functionality

b4c634b

Merge branch 'master' into bastian/webassembly

cbfcbd3

update to wasmtime v22

b67d23f

intgrate WebAssembly standard library values and types into existing …

e470d46

…standard library

lint

ead17b8

update copyright

e3c752f

improve config

f197db0

improve metering: always meter, even on failure

23795cb

disabling SIMD is broken

f6b6acf

bytecodealliance/wasmtime-go#222

fix check

8bcbf8c

limit store contents

12b56a5

add comments

9089bc6

update wasmtime

6b6c8fb

improve wasmtime setup

e55b81e

update wasmtime

8bd4f7f

add tests

d737d3d

convert wasmtime trap to generic stdlib trap error

efa0800

make trap error a user error

d9a6321

improve error for invalid non-function export

12817cb

improve error for WebAssembly module compilation failure

ab88756

convert wasmtime call trap into generic WebAssembly trap error

a3fe557

GetFuel/SetFuel should never error

9b4c462

add runtime interface method to get remaining computation for given kind

755d0d3

use new computation remaining for fuel

ef5d371

Merge branch 'master' into bastian/webassembly

2d42183

Merge branch 'master' into bastian/webassembly

e6c5f1b

fix merge: implement new runtime interface functions

d3cca43

update to wasmtime v25

c0a9bf1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PoC: WebAssembly API #2760

PoC: WebAssembly API #2760

turbolent commented Sep 1, 2023 •

edited

Loading

github-actions bot commented Sep 1, 2023 •

edited

Loading

codecov bot commented Sep 1, 2023 •

edited

Loading

PratikDhanave commented Sep 25, 2023 •

edited

Loading

darkdrag00nv2 commented Jan 3, 2024 •

edited

Loading

PoC: WebAssembly API #2760

Are you sure you want to change the base?

PoC: WebAssembly API #2760

Conversation

turbolent commented Sep 1, 2023 • edited Loading

Description

github-actions bot commented Sep 1, 2023 • edited Loading

Cadence Benchstat comparison

codecov bot commented Sep 1, 2023 • edited Loading

Codecov Report

PratikDhanave commented Sep 25, 2023 • edited Loading

darkdrag00nv2 commented Jan 3, 2024 • edited Loading

turbolent commented Sep 1, 2023 •

edited

Loading

github-actions bot commented Sep 1, 2023 •

edited

Loading

codecov bot commented Sep 1, 2023 •

edited

Loading

PratikDhanave commented Sep 25, 2023 •

edited

Loading

darkdrag00nv2 commented Jan 3, 2024 •

edited

Loading