Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to nginx @maintenance handler #168

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Changes to nginx @maintenance handler #168

wants to merge 3 commits into from

Commits on May 7, 2024

  1. Changes to nginx @maintenance handler 

    previous configuration would not display maintenance page if omero.web
wasn't running.  This was likely due to the request being passed to the
@proxy_to_app named location and the configuration not being inherited
into that stanza.

This commit moves the error_page directive up to the server container
where possible or duplicates the directive into the named location
directive otherwise.

Additionally the return code is set to 502 to avoid situations where
returning the maintenance page causes a 200 return code and confusing
monitoring systems.  (502 is always 502 with the current configuration.
    @stick @knabar
    stick authored and knabar committed May 7, 2024
    Configuration menu
    Copy the full SHA
    76fc6ec View commit details
    Browse the repository at this point in the history

  2. on Simon's advice... uncomment reffile.write_lines

    @stick @knabar
    stick authored and knabar committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c124237 View commit details
    Browse the repository at this point in the history

  3. Re-comment regeneration command 

    Co-authored-by: Simon Li <orpheus+devel@gmail.com>
    @joshmoore @manics @knabar
    2 people authored and knabar committed May 7, 2024
    Configuration menu
    Copy the full SHA
    06b0073 View commit details
    Browse the repository at this point in the history