Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop color key #112

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Drop color key #112

merged 4 commits into from
Jul 15, 2024

Conversation

will-moore
Copy link
Member

See ome/ome-zarr-py#389 cc @jni

This combines the version check for napari from that PR, along with @psobolewskiPhD's change.

Test viewing an image with labels (label colours are preserved) with napari 0.5.0 and with napari 0.4.x

E.g. red labels in

$ napari --plugin napari-ome-zarr https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0076A/10501752.zarr

Screenshot 2024-07-11 at 11 46 43

@will-moore
Copy link
Member Author

Test fixes included handling the metadata change from name to channel_names in ome/ome-zarr-py@cae02c8

The other failure was new with napari v0.5.0:

  >       viewer.window.qt_viewer.on_draw(None)
  E       AttributeError: 'QtViewer' object has no attribute 'on_draw'

I couldn't find what the correct method was to use instead of on_draw.
This also produces a warning:

FutureWarning: Public access to Window.qt_viewer is deprecated and will be removed in
  v0.6.0. It is considered an "implementation detail" of the napari
  application, not part of the napari viewer model. If your use case
  requires access to qt_viewer, please open an issue to discuss.

so it looks like this testing strategy won't be available soon anyway. My try/except AttributeError should handle both cases.

cc @joshmoore

@joshmoore joshmoore merged commit 4574e13 into ome:main Jul 15, 2024
14 checks passed
@joshmoore
Copy link
Member

@jni: https://pypi.org/project/napari-ome-zarr/0.6.1/ (0.6.0 failed for GH action reasons)

@jni
Copy link
Contributor

jni commented Jul 15, 2024

(0.6.0 failed for GH action reasons)

image

@psobolewskiPhD
Copy link
Contributor

Sorry to be late to this, but it works perfectly on my end. ❤️

@joshmoore
Copy link
Member

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants