Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] chart: trend line of area chart #5108

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

hokolomopo
Copy link
Contributor

Description

The trend line of area charts should not have a filled area under the line.

Also the trend line configuration should probably not inherit all the values of their parent dataset, as it's easy to miss thing and have options that make no sense (pointBackgroundColor being the color of the parent dataset rather than the color of the trend line for example).

Task: 4274294

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The trend line of area charts should not have a filled area under
the line.

Also the trend line configuration should probably not inherit all the
values of their parent dataset, as it's easy to miss thing and have
options that make no sense (pointBackgroundColor being the color
of the parent dataset rather than the color of the trend line for
example).

Task: 4274294
@robodoo
Copy link
Collaborator

robodoo commented Oct 21, 2024

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants