[IMP] charts: Add GeoChart type #5096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the use of color scales in the conditional format plugin and export the color scales to an helper. Now we have a simple `getColorScale` helper, that take as argument a number of value/color pairs (the thresholds) and return a function that computes a color based on a value and the provided value/color pairs. All the complexity of the color scale computation is now hidden in the helper, which simplify the use of color scale a lot and allows us to use them in other places. Task: 3265268
|
|
hokolomopo
force-pushed
the
master-geo-chart-adrm
branch
4 times, most recently
from
5e17110
to
fdff50e
Compare
This commit adds the geo chart type, which display a map of the world with countries highlighted based on the values in the sheet. The chart is drawn with the `chartjs-chart-geo` library that is an extension of Chart.js. To work, the geo chart need a `geoJsonService` given as parameter of the model that contains three methods: - `getAvailableRegions`: return the list of regions available - `getTopoJson`: return the topoJson/geoJson of a region - `geoFeatureNameToId`: convert an arbitrary string into a geo feature id present in the topoJson file Task: 3265268
Task: 3265268
hokolomopo
force-pushed
the
master-geo-chart-adrm
branch
from
fdff50e
to
ade5d95
Compare
Comment on lines
+54
to
+55
| - probably too many colorScales we should pick some to keep | ||
| - same for projections => probably pick, one projection by region and stick with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the geo chart type, which display a map of the world with countries highlighted based on the values in the sheet.
Task: 3265268
review checklist